Bug 113652

Summary: [Chromium] Yarr should build using a separate GYP file from JavaScriptCore
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dpranke, eric, jamesr, mrobinson, thakis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2013-03-30 21:04:04 PDT
[Chromium] Yarr should build using a separate GYP file from JavaScriptCore
Attachments
Patch (12.45 KB, patch)
2013-03-30 21:05 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2013-03-30 21:05:20 PDT
Created attachment 195886 [details] Patch
Nico Weber
Comment 2 2013-03-31 19:51:03 PDT
Duplicating the yarr files in two places makes sense to me as they don't change often, and the GTK port doesn't need the separate target from what I can tell. +mrobinson for his information.
Martin Robinson
Comment 3 2013-03-31 19:52:33 PDT
Comment on attachment 195886 [details] Patch This makes a lot of sense. :)
WebKit Review Bot
Comment 4 2013-03-31 20:05:18 PDT
Comment on attachment 195886 [details] Patch Clearing flags on attachment: 195886 Committed r147294: <http://trac.webkit.org/changeset/147294>
WebKit Review Bot
Comment 5 2013-03-31 20:05:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.