Bug 113627

Summary: [EFL][WK2] --no-tiled-backing-store build fails because of not used #if USE(ACCELERATED_COMPOSITING)
Product: WebKit Reporter: Ed Bartosh <bartosh>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: benjamin, commit-queue, dino, dstockwell, gyuyoung.kim, kenneth, kondapallykalyan, laszlo.gombos, lucas.de.marchi, mikhail.pozdnyakov, rakuco, simon.fraser, tmpsantos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 113153, 121159    
Description Flags
simon.fraser: review+, simon.fraser: commit-queue-
simon.fraser: review+, commit-queue: commit-queue-
Patch none

Description Ed Bartosh 2013-03-29 16:29:06 PDT
Here is just one example of compilation error:
WebCore/platform/graphics/TextTrackRepresentation.h:55:13: error: `PlatformLayer' does not name a type
Comment 1 Ed Bartosh 2013-03-29 16:51:15 PDT
Created attachment 195820 [details]
Comment 2 Ed Bartosh 2013-03-30 04:43:35 PDT
Created attachment 195854 [details]
Comment 3 Ed Bartosh 2013-04-01 01:06:18 PDT
Reverting back to UNCONFIRMED after reading https://bugs.webkit.org/page.cgi?id=fields.html#status
Comment 4 Ed Bartosh 2013-04-01 04:09:41 PDT
Added WK2 reviewer as patch also changes WK2 code.
Comment 5 Ed Bartosh 2013-04-02 13:37:41 PDT
Please, review!
Comment 6 Ed Bartosh 2013-04-04 14:04:46 PDT
Is there anything wrong with the patch? Why it's not reviewed?
Comment 7 Simon Fraser (smfr) 2013-04-04 14:07:55 PDT
Comment on attachment 195854 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=195854&action=review

> Source/WebCore/testing/Internals.cpp:267
> +#else
> +        { }

Why the #else block?
Comment 8 Ed Bartosh 2013-04-04 14:27:21 PDT
> Why the #else block?
Well, actually it's not needed as mainFrameView is not used further in the code. I'll update the patch this way:
    FrameView* mainFrameView = page->mainFrame()->view();
    if (mainFrameView) {

I'll also rebase it as it's quite old and might not apply.

Thank you for review!
Comment 9 Ed Bartosh 2013-04-04 14:38:35 PDT
Created attachment 196531 [details]

Updated according to reviewer comment.
Comment 10 Simon Fraser (smfr) 2013-04-05 11:54:52 PDT
Comment on attachment 196531 [details]

Pleaes request cq? when you request r? next time.
Comment 11 WebKit Commit Bot 2013-04-05 12:00:15 PDT
Comment on attachment 196531 [details]

Rejecting attachment 196531 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 196531, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
k #1 succeeded at 228 (offset 21 lines).
Hunk #2 succeeded at 531 (offset 13 lines).
Hunk #3 succeeded at 541 (offset 13 lines).
Hunk #4 succeeded at 556 (offset 13 lines).
Hunk #5 succeeded at 567 (offset 13 lines).
patching file Source/cmake/OptionsEfl.cmake
Hunk #1 succeeded at 176 (offset 1 line).
Hunk #2 succeeded at 251 (offset 1 line).

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Simon Fraser']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-commit-queue.appspot.com/results/17420352
Comment 12 Ed Bartosh 2013-04-05 12:19:35 PDT
Created attachment 196665 [details]

I'm sorry. My fault. 

Rebased. Requested r? and cq?.

Please, review.
Comment 13 WebKit Commit Bot 2013-04-05 13:28:10 PDT
Comment on attachment 196665 [details]

Clearing flags on attachment: 196665

Committed r147792: <http://trac.webkit.org/changeset/147792>
Comment 14 WebKit Commit Bot 2013-04-05 13:28:14 PDT
All reviewed patches have been landed.  Closing bug.