Bug 113627 – [EFL][WK2] --no-tiled-backing-store build fails because of not used #if USE(ACCELERATED_COMPOSITING)

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Ed Bartosh]

Here is just one example of compilation error:
WebCore/platform/graphics/TextTrackRepresentation.h:55:13: error: `PlatformLayer' does not name a type

[Ed Bartosh]

Created attachment 195820 [details]
Patch

[Ed Bartosh]

Created attachment 195854 [details]
Patch

[Ed Bartosh]

Reverting back to UNCONFIRMED after reading https://bugs.webkit.org/page.cgi?id=fields.html#status

[Ed Bartosh]

Added WK2 reviewer as patch also changes WK2 code.

[Ed Bartosh]

Please, review!

[Ed Bartosh]

Is there anything wrong with the patch? Why it's not reviewed?

[Simon Fraser (smfr)]

Comment on attachment 195854 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195854&action=review

> Source/WebCore/testing/Internals.cpp:267
> +#else
> +        { }

Why the #else block?

[Ed Bartosh]

> Why the #else block?
Well, actually it's not needed as mainFrameView is not used further in the code. I'll update the patch this way:
#if USE(ACCELERATED_COMPOSITING)
    FrameView* mainFrameView = page->mainFrame()->view();
    if (mainFrameView) {
         mainFrameView->setHeaderHeight(0);
         mainFrameView->setFooterHeight(0);
#endif

I'll also rebase it as it's quite old and might not apply.

Thank you for review!

[Ed Bartosh]

Created attachment 196531 [details]
Patch

Updated according to reviewer comment.

[Simon Fraser (smfr)]

Comment on attachment 196531 [details]
Patch

Pleaes request cq? when you request r? next time.

[WebKit Commit Bot]

Comment on attachment 196531 [details]
Patch

Rejecting attachment 196531 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 196531, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
k #1 succeeded at 228 (offset 21 lines).
Hunk #2 succeeded at 531 (offset 13 lines).
Hunk #3 succeeded at 541 (offset 13 lines).
Hunk #4 succeeded at 556 (offset 13 lines).
Hunk #5 succeeded at 567 (offset 13 lines).
patching file Source/cmake/OptionsEfl.cmake
Hunk #1 succeeded at 176 (offset 1 line).
Hunk #2 succeeded at 251 (offset 1 line).

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Simon Fraser']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-commit-queue.appspot.com/results/17420352

[Ed Bartosh]

Created attachment 196665 [details]
Patch

I'm sorry. My fault. 

Rebased. Requested r? and cq?.

Please, review.

[WebKit Commit Bot]

Comment on attachment 196665 [details]
Patch

Clearing flags on attachment: 196665

Committed r147792: <http://trac.webkit.org/changeset/147792>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.