Summary: | intrinsic size keywords don't work for heights | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ojan Vafai <ojan> | ||||
Component: | Layout and Rendering | Assignee: | Robert Hogan <robert> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | basile_clement, benjamin, bfulgham, cbiesinger, darin, esprehn, hyatt, kling, koivisto, marsjaninzmarsa, rego, robert, sam, simon.fraser, svillar, zalan | ||||
Priority: | P2 | Keywords: | BlinkMergeCandidate | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 146018 | ||||||
Attachments: |
|
Description
Ojan Vafai
2013-03-29 14:36:17 PDT
FYI, the blink version of this code was: https://codereview.chromium.org/13674002 https://code.google.com/p/chromium/issues/detail?id=226251 Note the followup in https://codereview.chromium.org/15112004/ Created attachment 254721 [details]
Patch
Pinging reviewers... Comment on attachment 254721 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254721&action=review Not at all fond of using the -1 magic value here. > Source/WebCore/css/CSSParser.cpp:1817 > +bool CSSParser::isValidSize(ValueWithCalculation& valueWithCalculation) If this has no side effects, maybe the argument type should be const& instead of just &. > Source/WebCore/rendering/RenderBox.cpp:2819 > + // FIXME: the css-sizing spec is considering changing what min-content/max-content should resolve to. Should be sentence style. Also should be called CSS sizing, not css-sizing. > Source/WebCore/rendering/RenderTable.cpp:374 > + } else if (styleLogicalHeight.isPercentOrCalculated()) { > computedLogicalHeight = computePercentageLogicalHeight(styleLogicalHeight); > + } else if (styleLogicalHeight.isIntrinsic()) WebKit code says no braces for this kind of thing. Committed r185908: <http://trac.webkit.org/changeset/185908> Removed LayoutTests/fast/css-intrinsic-dimensions/height-property-value.html.orig in http://trac.webkit.org/changeset/187549 |