Bug 113608

Summary: [Chromium] IndexedDB: Update terminated worker connection test
Product: WebKit Reporter: Joshua Bell <jsbell>
Component: New BugsAssignee: Joshua Bell <jsbell>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, dgrogan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Joshua Bell
Reported 2013-03-29 14:24:26 PDT
[Chromium] IndexedDB: Update terminated worker connection test
Attachments
Patch (6.43 KB, patch)
2013-03-29 14:30 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Patch (6.28 KB, patch)
2013-03-29 14:46 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2013-03-29 14:30:29 PDT
Created attachment 195799 [details] Patch
Joshua Bell
Comment 2 2013-03-29 14:32:09 PDT
This is a prerequisite for https://code.google.com/p/chromium/issues/detail?id=123418 This test is NOT run as a layout test under DRT (see TestExpectations) dgrogan@, alecflett@ - can you take a look?
David Grogan
Comment 3 2013-03-29 14:40:17 PDT
Comment on attachment 195799 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195799&action=review LGTM except for question about settimeout > LayoutTests/storage/indexeddb/pending-version-change-stuck-works-with-terminate.html:56 > + setTimeout(function() { Why is this necessary?
Joshua Bell
Comment 4 2013-03-29 14:45:51 PDT
Comment on attachment 195799 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195799&action=review >> LayoutTests/storage/indexeddb/pending-version-change-stuck-works-with-terminate.html:56 >> + setTimeout(function() { > > Why is this necessary? It's not - leftover from debugging. Removing it...
Joshua Bell
Comment 5 2013-03-29 14:46:42 PDT
Created attachment 195803 [details] Patch
Joshua Bell
Comment 6 2013-03-29 14:47:32 PDT
tony@ - one more r?
WebKit Review Bot
Comment 7 2013-03-29 15:08:24 PDT
Comment on attachment 195803 [details] Patch Clearing flags on attachment: 195803 Committed r147254: <http://trac.webkit.org/changeset/147254>
WebKit Review Bot
Comment 8 2013-03-29 15:08:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.