Bug 113608 - [Chromium] IndexedDB: Update terminated worker connection test
Summary: [Chromium] IndexedDB: Update terminated worker connection test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-29 14:24 PDT by Joshua Bell
Modified: 2013-03-29 15:08 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.43 KB, patch)
2013-03-29 14:30 PDT, Joshua Bell 		no flags Details | Formatted Diff | Diff
Patch (6.28 KB, patch)
2013-03-29 14:46 PDT, Joshua Bell 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2013-03-29 14:24:26 PDT 
[Chromium] IndexedDB: Update terminated worker connection test
Comment 1 Joshua Bell 2013-03-29 14:30:29 PDT 
Created attachment 195799 [details]
Patch
Comment 2 Joshua Bell 2013-03-29 14:32:09 PDT 
This is a prerequisite for https://code.google.com/p/chromium/issues/detail?id=123418

This test is NOT run as a layout test under DRT (see TestExpectations)

dgrogan@, alecflett@ - can you take a look?
Comment 3 David Grogan 2013-03-29 14:40:17 PDT 
Comment on attachment 195799 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195799&action=review

LGTM except for question about settimeout

> LayoutTests/storage/indexeddb/pending-version-change-stuck-works-with-terminate.html:56
> +            setTimeout(function() {

Why is this necessary?
Comment 4 Joshua Bell 2013-03-29 14:45:51 PDT 
Comment on attachment 195799 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195799&action=review

>> LayoutTests/storage/indexeddb/pending-version-change-stuck-works-with-terminate.html:56
>> +            setTimeout(function() {
> 
> Why is this necessary?

It's not - leftover from debugging. Removing it...
Comment 5 Joshua Bell 2013-03-29 14:46:42 PDT 
Created attachment 195803 [details]
Patch
Comment 6 Joshua Bell 2013-03-29 14:47:32 PDT 
tony@ - one more r?
Comment 7 WebKit Review Bot 2013-03-29 15:08:24 PDT 
Comment on attachment 195803 [details]
Patch

Clearing flags on attachment: 195803

Committed r147254: <http://trac.webkit.org/changeset/147254>
Comment 8 WebKit Review Bot 2013-03-29 15:08:28 PDT 
All reviewed patches have been landed.  Closing bug.