Bug 113600

Summary: [CSS Exclusions] shape-outside on floats fails to respect shape-margin's vertical extent
Product: WebKit Reporter: Hans Muller <giles_joplin>
Component: CSSAssignee: Hans Muller <giles_joplin>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, esprehn+autocc, ojan.autocc, rego+ews, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 113769    
Bug Blocks:    
Attachments:
Description Flags
Test case.
none
Test case screenshot.
none
Test case.
none
Patch
krit: review+, krit: commit-queue-
Patch none

Description Hans Muller 2013-03-29 13:10:56 PDT
Lines of text that fall below a shape-outside don't conform to the shape-margin boundary.  See that attached test case and screenshot.
Comment 1 Hans Muller 2013-03-29 13:11:24 PDT
Created attachment 195783 [details]
Test case.
Comment 2 Hans Muller 2013-03-29 13:14:42 PDT
Created attachment 195785 [details]
Test case screenshot.
Comment 3 Hans Muller 2013-03-29 13:15:31 PDT
Created attachment 195786 [details]
Test case.

Corrected a typo in the test cases's descriptive text.
Comment 4 Hans Muller 2013-03-29 18:38:00 PDT
Created attachment 195835 [details]
Patch
Comment 5 Dirk Schulze 2013-04-01 11:35:30 PDT
Comment on attachment 195835 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195835&action=review

LGTM. Just some snippets.

> Source/WebCore/ChangeLog:9
> +        ExclusionShapeOutsideInfo classes should depend on the ExclusionShape's margin boundary.  Added

"boundary. A" unnecessary whitespace.

> Source/WebCore/rendering/ExclusionShapeInsideInfo.h:101
> +    virtual FloatRect computedShapeLogicalBoundingBox() const { return computedShape()->shapePaddingLogicalBoundingBox(); }

Add OVERRIDE makro at the end.

> Source/WebCore/rendering/ExclusionShapeOutsideInfo.h:55
> +    virtual FloatRect computedShapeLogicalBoundingBox() const { return computedShape()->shapeMarginLogicalBoundingBox(); }

Ditto.
Comment 6 Hans Muller 2013-04-01 12:06:42 PDT
Created attachment 195999 [details]
Patch

Made the changes Dirk suggested.
Comment 7 WebKit Review Bot 2013-04-01 22:38:24 PDT
Comment on attachment 195999 [details]
Patch

Clearing flags on attachment: 195999

Committed r147384: <http://trac.webkit.org/changeset/147384>
Comment 8 WebKit Review Bot 2013-04-01 22:38:27 PDT
All reviewed patches have been landed.  Closing bug.