Bug 113574

Summary:

[Qt] Qt 5.1 related stuff add to the webkitpy.

Product:

WebKit

Reporter:

Ádám Kallai <kadam>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, allan.jensen, dpranke, eric, galpeter, ossy, webkit.review.bot, zarvai

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

114171

Attachments:

Description	Flags
proposed patch	ossy: commit-queue-

Description Ádám Kallai 2013-03-29 06:09:26 PDT

Prepare webkitpy for the arrival of Qt 5.1. The patch is coming soon.

Comment 1 Ádám Kallai 2013-03-29 06:20:13 PDT

Created attachment 195734 [details]
proposed patch

Comment 2 Csaba Osztrogonác 2013-03-29 06:23:58 PDT

Comment on attachment 195734 [details]
proposed patch

cq- now, I'm not sure if it is the best direction now.

Because with this change we should duplicate all 5.0 expectations 
for 5.1. But maybe 5.1 should fallback 5.0. I'm not sure which one
would be better, it needs more investigation.

Comment 3 Allan Sandfeld Jensen 2013-03-30 05:24:27 PDT

Hopefully we can remove 5.0 expectations shortly after converting to 5.1. Once we have all starting developing based on Qt 5.1 then there is little reason to keep the 5.0 baseline around.

Comment 4 Allan Sandfeld Jensen 2013-04-04 07:15:32 PDT

The way we are going to introduce the big rebaselines in 'qt 5.0', means that the best way forward would be to make qt 5.1 default to qt 5.0, or perhaps make a qt5 dir they both default to.

Comment 5 Allan Sandfeld Jensen 2013-09-11 08:12:35 PDT

The issues in this patch was solved in two other bugs which restructured the Qt layout results.

Comment 6 Anders Carlsson 2013-10-02 21:28:33 PDT

Comment on attachment 195734 [details]
proposed patch

Qt has been removed, clearing review flags.