| Summary: | Remove unnecessary 1 second sleep on windows from preprocessor.pm | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||
| Component: | New Bugs | Assignee: | James Robinson <jamesr> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, haraken, japhet, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
James Robinson
2013-03-28 14:15:54 PDT
Created attachment 195639 [details]
Patch
Comment on attachment 195639 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195639&action=review > Source/WebCore/ChangeLog:8 > + > + This regressed in 146661 You should comment that this made the build 12 minutes longer. :) Sell it, man! :p (In reply to comment #2) > (From update of attachment 195639 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=195639&action=review > > > Source/WebCore/ChangeLog:8 > > + > > + This regressed in 146661 > > You should comment that this made the build 12 minutes longer. :) Sell it, man! :p I'm actually not 100% sure on that point - do we run the preprocessors in parallel? Comment on attachment 195639 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195639&action=review >>> Source/WebCore/ChangeLog:8 >>> + This regressed in 146661 >> >> You should comment that this made the build 12 minutes longer. :) Sell it, man! :p > > I'm actually not 100% sure on that point - do we run the preprocessors in parallel? What was this sleep for? I couldn't find a rationale from a ChangeLog of r146661 (http://trac.webkit.org/changeset/146661). Committed r147157: <http://trac.webkit.org/changeset/147157> |