Bug 113536

Summary: Remove unnecessary 1 second sleep on windows from preprocessor.pm
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, haraken, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

James Robinson
Reported 2013-03-28 14:15:54 PDT
Remove unnecessary 1 second sleep on windows from preprocessor.pm
Attachments
Patch (1.38 KB, patch)
2013-03-28 14:16 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2013-03-28 14:16:17 PDT
Created attachment 195639 [details] Patch
Eric Seidel (no email)
Comment 2 2013-03-28 14:19:00 PDT
Comment on attachment 195639 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195639&action=review > Source/WebCore/ChangeLog:8 > + > + This regressed in 146661 You should comment that this made the build 12 minutes longer. :) Sell it, man! :p
James Robinson
Comment 3 2013-03-28 14:19:33 PDT
(In reply to comment #2) > (From update of attachment 195639 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=195639&action=review > > > Source/WebCore/ChangeLog:8 > > + > > + This regressed in 146661 > > You should comment that this made the build 12 minutes longer. :) Sell it, man! :p I'm actually not 100% sure on that point - do we run the preprocessors in parallel?
Kentaro Hara
Comment 4 2013-03-28 14:21:45 PDT
Comment on attachment 195639 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195639&action=review >>> Source/WebCore/ChangeLog:8 >>> + This regressed in 146661 >> >> You should comment that this made the build 12 minutes longer. :) Sell it, man! :p > > I'm actually not 100% sure on that point - do we run the preprocessors in parallel? What was this sleep for? I couldn't find a rationale from a ChangeLog of r146661 (http://trac.webkit.org/changeset/146661).
James Robinson
Comment 5 2013-03-28 14:29:49 PDT
Committed r147157: <http://trac.webkit.org/changeset/147157>
Note You need to log in before you can comment on or make changes to this bug.