Bug 113528

Summary: REGRESSION: run-perf-tests --profiler= seems to have broken
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, darin, dbates, glenn, leviw, ojan, pdr, rniwa, simon.fraser, svillar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch dbates: review+

Eric Seidel (no email)
Reported 2013-03-28 12:33:06 PDT
REGRESSION: run-perf-tests --profiler seems to have broken --profiler=pprof used to let you use the pprof profiler on linux for example. Now it no longer seems to work. Something (probably my fault) broke at some point in recent memory.
Attachments
Patch (1.87 KB, patch)
2015-01-23 04:11 PST, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Patch (3.06 KB, patch)
2015-01-23 05:39 PST, Sergio Villar Senin 		dbates: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2015-01-23 04:06:32 PST
Not sure if the failure is the same than the one reported by Eric but it definitely does not work in GTK (and I guess that also in EFL) when using jhbuild to build. The problem is that "perf --record" is never called because we just wrap the command with jhbuild-run.
Sergio Villar Senin
Comment 2 2015-01-23 04:11:07 PST
Created attachment 245221 [details] Patch
Sergio Villar Senin
Comment 3 2015-01-23 05:39:05 PST
Created attachment 245224 [details] Patch Now with unit test
Daniel Bates
Comment 4 2015-01-23 06:45:04 PST
Comment on attachment 245224 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245224&action=review > Tools/Scripts/webkitpy/port/driver.py:228 > + wrapper = [] Maybe a better name for this variable would be wrapper_arguments.
Sergio Villar Senin
Comment 5 2015-01-23 06:48:53 PST
(In reply to comment #4) > Comment on attachment 245224 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=245224&action=review > > > Tools/Scripts/webkitpy/port/driver.py:228 > > + wrapper = [] > > Maybe a better name for this variable would be wrapper_arguments. Okidoki
Sergio Villar Senin
Comment 6 2015-01-23 06:56:57 PST
Committed r179008: <http://trac.webkit.org/changeset/179008>
Note You need to log in before you can comment on or make changes to this bug.