Bug 113512

Summary: [GStreamer] playback gets bumpy sometimes when on-disk buffering is slow
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, feature-media-reviews, gustavo, jer.noble, menard, mrobinson, pnormand, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch mrobinson: review+

Philippe Normand
Reported 2013-03-28 10:09:25 PDT
We should pause the pipeline when we get a buffering message that is not the final one. This is a strong advice from the GStreamer developers :)
Attachments
patch (2.09 KB, patch)
2013-03-28 10:12 PDT, Philippe Normand 		mrobinson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2013-03-28 10:12:55 PDT
Created attachment 195589 [details] patch
Martin Robinson
Comment 2 2013-03-28 10:17:49 PDT
Comment on attachment 195589 [details] patch Does the player automatically unpause?
Philippe Normand
Comment 3 2013-03-28 10:39:15 PDT
(In reply to comment #2) > (From update of attachment 195589 [details]) > Does the player automatically unpause? Yes when buffering is finished and also once the pipeline pre-rolled.
Martin Robinson
Comment 4 2013-03-28 10:43:06 PDT
Comment on attachment 195589 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=195589&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:806 > + if (!m_paused && (m_bufferingPercentage < 100)) { You can probably dispense with the inner parenthesis here.
Philippe Normand
Comment 5 2013-03-29 04:28:35 PDT
Committed r147206: <http://trac.webkit.org/changeset/147206>
Note You need to log in before you can comment on or make changes to this bug.