Bug 113497

Summary:

Web Inspector: Heap snapshots retained size falls out of the grid if column is too narrow

Product:

WebKit

Reporter:

Alexei Filippov <alph>

Component:

Web Inspector (Deprecated)

Assignee:

Alexei Filippov <alph>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
screenshot	none
Patch	none
Patch	none
Patch	none

Alexei Filippov

Reported 2013-03-28 03:32:46 PDT

Created attachment 195516 [details] screenshot See the screenshot.

Attachments
screenshot (17.45 KB, image/png) 2013-03-28 03:32 PDT, Alexei Filippov	no flags	Details
Patch (1.35 KB, patch) 2013-03-28 03:36 PDT, Alexei Filippov	no flags	Details Formatted Diff Diff
Patch (2.20 KB, patch) 2013-03-28 05:19 PDT, Alexei Filippov	no flags	Details Formatted Diff Diff
Patch (2.24 KB, patch) 2013-03-28 05:44 PDT, Alexei Filippov	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Alexei Filippov

Comment 1 2013-03-28 03:36:34 PDT

Created attachment 195519 [details] Patch

Build Bot

Comment 2 2013-03-28 04:51:59 PDT

Comment on attachment 195519 [details] Patch Attachment 195519 [details] did not pass win-ews (win): Output: http://webkit-commit-queue.appspot.com/results/17353061

Pavel Feldman

Comment 3 2013-03-28 05:00:18 PDT

Comment on attachment 195519 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195519&action=review > Source/WebCore/inspector/front-end/heapProfiler.css:87 > +.heap-snapshot-view .data-grid td:not(.object-column) > div { This rule seems to be too broad. Any div child of td? does it have a class name or identifier?

Alexei Filippov

Comment 4 2013-03-28 05:19:12 PDT

Created attachment 195537 [details] Patch

Pavel Feldman

Comment 5 2013-03-28 05:35:52 PDT

Comment on attachment 195537 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195537&action=review > Source/WebCore/inspector/front-end/heapProfiler.css:127 > +.heap-snapshot-view .data-grid div.multiple-values { please rename multiple-values to .head-shapshot-multiple-values. Otherwise it might clash with some other panels.

Alexei Filippov

Comment 6 2013-03-28 05:44:24 PDT

Created attachment 195540 [details] Patch

Alexei Filippov

Comment 7 2013-03-28 05:44:40 PDT

Comment on attachment 195537 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195537&action=review >> Source/WebCore/inspector/front-end/heapProfiler.css:127 >> +.heap-snapshot-view .data-grid div.multiple-values { > > please rename multiple-values to .head-shapshot-multiple-values. Otherwise it might clash with some other panels. done

WebKit Review Bot

Comment 8 2013-03-28 06:06:00 PDT

Comment on attachment 195540 [details] Patch Clearing flags on attachment: 195540 Committed r147103: <http://trac.webkit.org/changeset/147103>

WebKit Review Bot

Comment 9 2013-03-28 06:06:04 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.