Bug 113496

Summary: Web Inspector: [Cookies] CookiesTable should integrate with DataGrid context menu.
Product: WebKit Reporter: Eugene Klyuchnikov <eustas>
Component: Web Inspector (Deprecated)Assignee: Eugene Klyuchnikov <eustas>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Eugene Klyuchnikov 2013-03-28 03:28:52 PDT 
In recent path CookiesTable added context menu listener on DataGrid element to override behavior.

Integrating with DataGrid instead of overriding looks better.

Actually that patch is reduced version of patch that was waiting for better back-end cookies management.
Comment 1 Eugene Klyuchnikov 2013-03-28 03:34:40 PDT 
Created attachment 195517 [details]
Patch
Comment 2 Pavel Feldman 2013-03-28 05:02:11 PDT 
Comment on attachment 195517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195517&action=review

> Source/WebCore/inspector/front-end/CookiesTable.js:281
> +    _refresh: function() {

{ on the next line.

> Source/WebCore/inspector/front-end/CookiesTable.js:282
> +        this._refreshCallback && this._refreshCallback();

We never do this, please use explicit if.

> Source/WebCore/inspector/front-end/DataGrid.js:33
> + * @param {?function(!WebInspector.ContextMenu, WebInspector.DataGridNode)=} contextMenuCallback

We don't use nullable optional fields. Please remove ? from here and above.
Comment 3 Eugene Klyuchnikov 2013-03-28 22:28:21 PDT 
Comment on attachment 195517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195517&action=review

>> Source/WebCore/inspector/front-end/CookiesTable.js:281
>> +    _refresh: function() {
> 
> { on the next line.

oops. fixed

>> Source/WebCore/inspector/front-end/CookiesTable.js:282
>> +        this._refreshCallback && this._refreshCallback();
> 
> We never do this, please use explicit if.

Done.

>> Source/WebCore/inspector/front-end/DataGrid.js:33
>> + * @param {?function(!WebInspector.ContextMenu, WebInspector.DataGridNode)=} contextMenuCallback
> 
> We don't use nullable optional fields. Please remove ? from here and above.

OK
Comment 4 Eugene Klyuchnikov 2013-03-28 22:33:12 PDT 
Created attachment 195697 [details]
Patch
Comment 5 WebKit Review Bot 2013-03-28 23:29:42 PDT 
Comment on attachment 195697 [details]
Patch

Clearing flags on attachment: 195697

Committed r147198: <http://trac.webkit.org/changeset/147198>
Comment 6 WebKit Review Bot 2013-03-28 23:29:45 PDT 
All reviewed patches have been landed.  Closing bug.