Bug 113494

Summary: [EFL] Enable user-select:all for EFL port
Product: WebKit Reporter: Jinwoo Song <jinwoo7.song>
Component: WebKit EFLAssignee: Jinwoo Song <jinwoo7.song>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jinwoo Song
Reported 2013-03-28 02:45:13 PDT
SSIA.
Attachments
Patch (4.22 KB, patch)
2013-03-28 03:01 PDT, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Patch (4.22 KB, patch)
2013-03-28 16:27 PDT, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jinwoo Song
Comment 1 2013-03-28 03:01:33 PDT
Created attachment 195513 [details] Patch
Build Bot
Comment 2 2013-03-28 04:30:33 PDT
Comment on attachment 195513 [details] Patch Attachment 195513 [details] did not pass win-ews (win): Output: http://webkit-commit-queue.appspot.com/results/17353054
Jinwoo Song
Comment 3 2013-03-28 16:27:48 PDT
Created attachment 195673 [details] Patch
Build Bot
Comment 4 2013-03-28 18:01:11 PDT
Comment on attachment 195673 [details] Patch Attachment 195673 [details] did not pass win-ews (win): Output: http://webkit-commit-queue.appspot.com/results/17356061
Gyuyoung Kim
Comment 5 2013-03-29 00:38:56 PDT
Comment on attachment 195673 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195673&action=review > LayoutTests/platform/efl/TestExpectations:-1535 > -webkit.org/b/100424 editing/selection/user-select-all-selection.html [ Failure ] Don't you need to rebaseline this test case ? When I run this test with your patch, this test was failed.
Jinwoo Song
Comment 6 2013-03-30 00:19:00 PDT
(In reply to comment #5) > (From update of attachment 195673 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=195673&action=review > > > LayoutTests/platform/efl/TestExpectations:-1535 > > -webkit.org/b/100424 editing/selection/user-select-all-selection.html [ Failure ] > > Don't you need to rebaseline this test case ? When I run this test with your patch, this test was failed. When I tested the case in my local, it has passed. I have double checked in other PC, too. Could you let me know how tested the case?
Gyuyoung Kim
Comment 7 2013-03-31 18:35:04 PDT
Comment on attachment 195673 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195673&action=review LGTM. >>> LayoutTests/platform/efl/TestExpectations:-1535 >>> -webkit.org/b/100424 editing/selection/user-select-all-selection.html [ Failure ] >> >> Don't you need to rebaseline this test case ? When I run this test with your patch, this test was failed. > > When I tested the case in my local, it has passed. I have double checked in other PC, too. Could you let me know how tested the case? Hmm, there was something wrong. This test is passed on my pc now. Sorry for noise.
Jinwoo Song
Comment 8 2013-03-31 21:55:20 PDT
(In reply to comment #4) > (From update of attachment 195673 [details]) > Attachment 195673 [details] did not pass win-ews (win): > Output: http://webkit-commit-queue.appspot.com/results/17356061 Unrelated error with this patch.
WebKit Review Bot
Comment 9 2013-04-01 00:02:41 PDT
Comment on attachment 195673 [details] Patch Clearing flags on attachment: 195673 Committed r147306: <http://trac.webkit.org/changeset/147306>
WebKit Review Bot
Comment 10 2013-04-01 00:02:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.