Bug 113494

Summary: [EFL] Enable user-select:all for EFL port
Product: WebKit Reporter: Jinwoo Song <jinwoo7.song>
Component: WebKit EFLAssignee: Jinwoo Song <jinwoo7.song>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Jinwoo Song 2013-03-28 02:45:13 PDT
SSIA.
Comment 1 Jinwoo Song 2013-03-28 03:01:33 PDT
Created attachment 195513 [details]
Patch
Comment 2 Build Bot 2013-03-28 04:30:33 PDT
Comment on attachment 195513 [details]
Patch

Attachment 195513 [details] did not pass win-ews (win):
Output: http://webkit-commit-queue.appspot.com/results/17353054
Comment 3 Jinwoo Song 2013-03-28 16:27:48 PDT
Created attachment 195673 [details]
Patch
Comment 4 Build Bot 2013-03-28 18:01:11 PDT
Comment on attachment 195673 [details]
Patch

Attachment 195673 [details] did not pass win-ews (win):
Output: http://webkit-commit-queue.appspot.com/results/17356061
Comment 5 Gyuyoung Kim 2013-03-29 00:38:56 PDT
Comment on attachment 195673 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195673&action=review

> LayoutTests/platform/efl/TestExpectations:-1535
> -webkit.org/b/100424 editing/selection/user-select-all-selection.html [ Failure ]

Don't you need to rebaseline this test case ? When I run this test with your patch, this test was failed.
Comment 6 Jinwoo Song 2013-03-30 00:19:00 PDT
(In reply to comment #5)
> (From update of attachment 195673 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=195673&action=review
> 
> > LayoutTests/platform/efl/TestExpectations:-1535
> > -webkit.org/b/100424 editing/selection/user-select-all-selection.html [ Failure ]
> 
> Don't you need to rebaseline this test case ? When I run this test with your patch, this test was failed.

When I tested the case in my local, it has passed. I have double checked in other PC, too. Could you let me know how tested the case?
Comment 7 Gyuyoung Kim 2013-03-31 18:35:04 PDT
Comment on attachment 195673 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195673&action=review

LGTM.

>>> LayoutTests/platform/efl/TestExpectations:-1535
>>> -webkit.org/b/100424 editing/selection/user-select-all-selection.html [ Failure ]
>> 
>> Don't you need to rebaseline this test case ? When I run this test with your patch, this test was failed.
> 
> When I tested the case in my local, it has passed. I have double checked in other PC, too. Could you let me know how tested the case?

Hmm, there was something wrong. This test is passed on my pc now. Sorry for noise.
Comment 8 Jinwoo Song 2013-03-31 21:55:20 PDT
(In reply to comment #4)
> (From update of attachment 195673 [details])
> Attachment 195673 [details] did not pass win-ews (win):
> Output: http://webkit-commit-queue.appspot.com/results/17356061

Unrelated error with this patch.
Comment 9 WebKit Review Bot 2013-04-01 00:02:41 PDT
Comment on attachment 195673 [details]
Patch

Clearing flags on attachment: 195673

Committed r147306: <http://trac.webkit.org/changeset/147306>
Comment 10 WebKit Review Bot 2013-04-01 00:02:45 PDT
All reviewed patches have been landed.  Closing bug.