Bug 113486

Summary: Web Inspector: [Network] Split business logic and presentation for initiator column.
Product: WebKit Reporter: Eugene Klyuchnikov <eustas>
Component: Web Inspector (Deprecated)Assignee: Eugene Klyuchnikov <eustas>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Eugene Klyuchnikov 2013-03-28 00:59:50 PDT 
Currently business logic and presentation are mixed.
This prevents making cell renderer static and applying viewport rendering,
because initiator sorting function depends on data written when cell is rendered.

In this patch initiator information is extracted in separate method.
Comment 1 Eugene Klyuchnikov 2013-03-28 02:14:55 PDT 
Created attachment 195505 [details]
Patch
Comment 2 Pavel Feldman 2013-03-28 02:48:56 PDT 
Comment on attachment 195505 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195505&action=review

> Source/WebCore/inspector/front-end/NetworkPanel.js:2475
> +    var aInitiator = WebInspector.NetworkDataGridNode.buildInitiatorInfo(a._request);

You are creating it while sorting.
Comment 3 Eugene Klyuchnikov 2013-03-28 03:01:10 PDT 
Comment on attachment 195505 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195505&action=review

>> Source/WebCore/inspector/front-end/NetworkPanel.js:2475
>> +    var aInitiator = WebInspector.NetworkDataGridNode.buildInitiatorInfo(a._request);
> 
> You are creating it while sorting.

In first (unpublished) version of patch I've created/cached it in NetworkRequest.
But I thought you wouldn't accept it.

So, would you like if initiatorInfo will be cached in NetworkRequest instance?
Comment 4 Eugene Klyuchnikov 2013-03-29 00:51:06 PDT 
Created attachment 195705 [details]
Patch
Comment 5 WebKit Review Bot 2013-04-02 22:58:46 PDT 
Comment on attachment 195705 [details]
Patch

Clearing flags on attachment: 195705

Committed r147519: <http://trac.webkit.org/changeset/147519>
Comment 6 WebKit Review Bot 2013-04-02 22:58:50 PDT 
All reviewed patches have been landed.  Closing bug.