Bug 113460

Summary: Web Inspector: Update test expectation for resource-har-conversion.html
Product: WebKit Reporter: Seokju Kwon <seokju>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, caseq, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 113586, 113677    
Attachments:
Description Flags
Patch
none
Patch none

Seokju Kwon
Reported 2013-03-27 17:12:35 PDT
The value of pageref and title had been changed after r105596. -use page ids, not document URLs in HAR entries to refer to pages -use page URL as a title field of a HAR page
Attachments
Patch (2.71 KB, patch)
2013-03-27 17:13 PDT, Seokju Kwon 		no flags
DetailsFormatted DiffDiff
Patch (8.73 KB, patch)
2013-03-28 16:28 PDT, Seokju Kwon 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Seokju Kwon
Comment 1 2013-03-27 17:13:44 PDT
Created attachment 195442 [details] Patch
Andrey Kosyakov
Comment 2 2013-03-28 04:43:06 PDT
LGTM
Andrey Kosyakov
Comment 3 2013-03-28 04:46:26 PDT
I think you might also want to remove suppressions in TestExpectations for this test. Also, please check platform-specific expectation overrides.
Vsevolod Vlasov
Comment 4 2013-03-28 04:47:20 PDT
Comment on attachment 195442 [details] Patch As Andrey said please update test expectations before landing.
Seokju Kwon
Comment 5 2013-03-28 16:26:19 PDT
(In reply to comment #4) > (From update of attachment 195442 [details]) > As Andrey said please update test expectations before landing. Andrey Kosyakov, Vsevolod Vlasov Thank you for review. :) I will override platform-specific expectation as well. But almost platforms have different bug number in TestExpectations. So I will take a look at it after landing this patch.
Seokju Kwon
Comment 6 2013-03-28 16:28:10 PDT
Created attachment 195674 [details] Patch
WebKit Review Bot
Comment 7 2013-03-29 08:08:05 PDT
Comment on attachment 195674 [details] Patch Clearing flags on attachment: 195674 Committed r147219: <http://trac.webkit.org/changeset/147219>
WebKit Review Bot
Comment 8 2013-03-29 08:08:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.