Bug 113447

Summary: [BlackBerry] Don't use WebKit thread scale information in WebPageCompositor
Product: WebKit Reporter: Jakob Petsovits <jpetsovits>
Component: WebKit BlackBerryAssignee: Jakob Petsovits <jpetsovits>
Status: RESOLVED FIXED    
Severity: Normal CC: anilsson, mifenton, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jakob Petsovits
Reported 2013-03-27 14:57:01 PDT
WebPageCompositor and the related BackingStore member function compositeContents() are using WebKit thread data on the user interface thread, without synchronization primitives or anything. That's bad and should be fixed. Potential threading problems can be avoided by moving from WebPage members and mapToTransformed() to the web page client's userInterfaceViewportAccessor(). As part of this cleaning effort, the WebPageCompositor's render() method is changed to now take document instead of pixel coordinates.
Attachments
Patch (10.80 KB, patch)
2013-03-27 15:03 PDT, Jakob Petsovits 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jakob Petsovits
Comment 1 2013-03-27 15:03:04 PDT
Created attachment 195404 [details] Patch
Arvid Nilsson
Comment 2 2013-03-27 23:00:27 PDT
Comment on attachment 195404 [details] Patch Looks great!
Rob Buis
Comment 3 2013-03-28 07:06:19 PDT
Comment on attachment 195404 [details] Patch LGTM.
WebKit Review Bot
Comment 4 2013-03-28 11:42:23 PDT
Comment on attachment 195404 [details] Patch Clearing flags on attachment: 195404 Committed r147136: <http://trac.webkit.org/changeset/147136>
WebKit Review Bot
Comment 5 2013-03-28 11:42:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.