Bug 113406

Summary: [Mac] Text track menu items sometimes labeled incorrectly
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, feature-media-reviews, jer.noble, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch none

Description Eric Carlson 2013-03-27 07:11:56 PDT
Text track menu items with both 'label' and 'srclang' attributes are not correct.
Comment 1 Eric Carlson 2013-03-27 07:15:37 PDT
Created attachment 195311 [details]
Proposed patch
Comment 2 Radar WebKit Bug Importer 2013-03-27 07:15:58 PDT
<rdar://problem/13515337>
Comment 3 Jer Noble 2013-03-27 09:48:22 PDT
Comment on attachment 195311 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195311&action=review

r+, with nit:

> Source/WebCore/page/CaptionUserPreferencesMac.mm:541
> +        if (language.isEmpty() || label.contains(language)) {
> +            displayName.append(label);
> +        } else {

Unnecessary braces.
Comment 4 Eric Carlson 2013-03-27 11:32:03 PDT
https://trac.webkit.org/r147000