Summary: | [Mac] Text track menu items sometimes labeled incorrectly | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||
Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dino, feature-media-reviews, jer.noble, webkit-bug-importer, webkit.review.bot | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Eric Carlson
2013-03-27 07:11:56 PDT
Created attachment 195311 [details]
Proposed patch
Comment on attachment 195311 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=195311&action=review r+, with nit: > Source/WebCore/page/CaptionUserPreferencesMac.mm:541 > + if (language.isEmpty() || label.contains(language)) { > + displayName.append(label); > + } else { Unnecessary braces. |