Bug 113392

Summary:

[Mac] Use fontName rather than familyName for internal fonts

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

Text

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, esprehn+autocc, mitz, ojan.autocc, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	enrica: review+, buildbot: commit-queue-

Description Dean Jackson 2013-03-27 04:52:15 PDT

Some internal fonts for OS X are not listed in availableFontFamilies, which means that WebCore fails to find them. In these cases we should look for the fontName, rather than the familyName.

<rdar://problem/13474743>

Comment 1 Dean Jackson 2013-03-27 04:56:32 PDT

Created attachment 195279 [details]
Patch

Comment 2 Build Bot 2013-03-27 06:40:02 PDT

Comment on attachment 195279 [details]
Patch

Attachment 195279 [details] did not pass win-ews (win):
Output: http://webkit-commit-queue.appspot.com/results/17257428

Comment 3 Enrica Casucci 2013-03-27 08:04:55 PDT

Comment on attachment 195279 [details]
Patch

Looks good

Comment 4 Dean Jackson 2013-03-27 10:43:30 PDT

Not sure what is up with the windows tests:
svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg -> failed

Comment 5 Dean Jackson 2013-03-27 10:48:19 PDT

Since the files changed here aren't even compiled on Windows, it seems like a misleading result. I'll keep an eye on the test bots.

Comment 6 Dean Jackson 2013-03-27 10:52:08 PDT

Committed r146995: <http://trac.webkit.org/changeset/146995>