| Summary: | [Chromium] Enable touch events in PagePopup | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keishi Hattori <keishi> | ||||||
| Component: | Forms | Assignee: | Keishi Hattori <keishi> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, dglazkov, fishd, jamesr, tkent, tkent+wkapi, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Keishi Hattori
2013-03-27 02:42:09 PDT
Created attachment 195253 [details]
Patch
Comment on attachment 195253 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195253&action=review > Source/WebKit/chromium/src/WebPagePopupImpl.cpp:144 > + m_popup->hasTouchEventHandlers(needsTouchEvents); You can use m_popup->widgetClient(). Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Created attachment 195255 [details]
Patch
Comment on attachment 195255 [details]
Patch
ok
Comment on attachment 195255 [details] Patch Rejecting attachment 195255 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 195255, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: return self.open(self.click(*args, **kwds)) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open return self._mech_open(url, data, timeout=timeout) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open raise response webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error Full output: http://webkit-commit-queue.appspot.com/results/17339174 Comment on attachment 195255 [details] Patch Clearing flags on attachment: 195255 Committed r147045: <http://trac.webkit.org/changeset/147045> All reviewed patches have been landed. Closing bug. |