Bug 113380 – [Chromium] Enable touch events in PagePopup

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Keishi Hattori]

[Chromium] Enable touch events in PagePopup

[Keishi Hattori]

Created attachment 195253 [details]
Patch

[Kent Tamura]

Comment on attachment 195253 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195253&action=review

> Source/WebKit/chromium/src/WebPagePopupImpl.cpp:144
> +        m_popup->hasTouchEventHandlers(needsTouchEvents);

You can use m_popup->widgetClient().

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Keishi Hattori]

Created attachment 195255 [details]
Patch

[Kent Tamura]

Comment on attachment 195255 [details]
Patch

ok

[WebKit Review Bot]

Comment on attachment 195255 [details]
Patch

Rejecting attachment 195255 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 195255, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
  return self.open(self.click(*args, **kwds))
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open
    return self._mech_open(url, data, timeout=timeout)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open
    raise response
webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error

Full output: http://webkit-commit-queue.appspot.com/results/17339174

[WebKit Review Bot]

Comment on attachment 195255 [details]
Patch

Clearing flags on attachment: 195255

Committed r147045: <http://trac.webkit.org/changeset/147045>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.