Bug 113380 - [Chromium] Enable touch events in PagePopup
Summary: [Chromium] Enable touch events in PagePopup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-27 02:42 PDT by Keishi Hattori
Modified: 2013-03-27 19:15 PDT (History)
7 users (show)

See Also:


Attachments
Patch (3.99 KB, patch)
2013-03-27 02:50 PDT, Keishi Hattori
no flags Details | Formatted Diff | Diff
Patch (2.98 KB, patch)
2013-03-27 03:00 PDT, Keishi Hattori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2013-03-27 02:42:09 PDT
[Chromium] Enable touch events in PagePopup
Comment 1 Keishi Hattori 2013-03-27 02:50:34 PDT
Created attachment 195253 [details]
Patch
Comment 2 Kent Tamura 2013-03-27 02:53:25 PDT
Comment on attachment 195253 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195253&action=review

> Source/WebKit/chromium/src/WebPagePopupImpl.cpp:144
> +        m_popup->hasTouchEventHandlers(needsTouchEvents);

You can use m_popup->widgetClient().
Comment 3 WebKit Review Bot 2013-03-27 02:54:11 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Keishi Hattori 2013-03-27 03:00:58 PDT
Created attachment 195255 [details]
Patch
Comment 5 Kent Tamura 2013-03-27 03:05:34 PDT
Comment on attachment 195255 [details]
Patch

ok
Comment 6 WebKit Review Bot 2013-03-27 17:02:19 PDT
Comment on attachment 195255 [details]
Patch

Rejecting attachment 195255 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 195255, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
  return self.open(self.click(*args, **kwds))
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open
    return self._mech_open(url, data, timeout=timeout)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open
    raise response
webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error

Full output: http://webkit-commit-queue.appspot.com/results/17339174
Comment 7 WebKit Review Bot 2013-03-27 19:15:52 PDT
Comment on attachment 195255 [details]
Patch

Clearing flags on attachment: 195255

Committed r147045: <http://trac.webkit.org/changeset/147045>
Comment 8 WebKit Review Bot 2013-03-27 19:15:55 PDT
All reviewed patches have been landed.  Closing bug.