Bug 113376

Summary: Web Inspector: update Timeline.TimelineEvent definition to include DOM counters and native memory stats
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, graouts, joepeck, keishi, loislo, pfeldman, pmuellr, timothy, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch vsevik: review+, vsevik: commit-queue+

Yury Semikhatsky
Reported 2013-03-27 02:00:49 PDT
The event already can contain optional DOM counters and native memory stats. This should be reflected in Inspector.json
Attachments
Patch (7.71 KB, patch)
2013-03-27 02:05 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (1.64 KB, patch)
2013-03-27 05:43 PDT, Yury Semikhatsky 		vsevik: review+
vsevik: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2013-03-27 02:05:39 PDT
Created attachment 195250 [details] Patch
Yury Semikhatsky
Comment 2 2013-03-27 02:31:42 PDT
Committed r146975: <http://trac.webkit.org/changeset/146975>
Yury Semikhatsky
Comment 3 2013-03-27 05:43:46 PDT
Reopening to attach new patch.
Yury Semikhatsky
Comment 4 2013-03-27 05:43:49 PDT
Created attachment 195290 [details] Patch
Yury Semikhatsky
Comment 5 2013-03-27 05:45:08 PDT
(In reply to comment #4) > Created an attachment (id=195290) [details] > Patch Previous change caused assertion failure in debug mode in timeline tests(http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/7509/steps/webkit_tests/logs/stdio). This is a fix.
Yury Semikhatsky
Comment 6 2013-03-27 07:25:42 PDT
Committed r146982: <http://trac.webkit.org/changeset/146982>
Note You need to log in before you can comment on or make changes to this bug.