Bug 113334

Summary: [BlackBerry] RSS reader filter swallows headers when there is no body
Product: WebKit Reporter: Joe Mason <joenotcharles>
Component: Page LoadingAssignee: Joe Mason <joenotcharles>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Unspecified   
Attachments:
Description Flags
fix
none
fix none

Joe Mason
Reported 2013-03-26 12:30:31 PDT
When receiving an HTTP response that has a Content-Type header such as text/xml, but no body, RSSFilterStream::notifyHeadersReceived reads the Content-Type as "potential RSS", and calls saveHeaders. It expects to sniff the body in notifyDataReceived to see if it's RSS, and then call sendSavedHeaders to pass on the headers. But notifyDataReceived is never called since there's no body, so neither is sendSavedHeaders. The result is that NetworkJob sees "notifyStatusReceived; notifyClose" instead of "notifyStatusReceived; notifyHeadersReceived; notifyClose".
Attachments
fix (1.28 KB, patch)
2013-03-26 12:41 PDT, Joe Mason 		no flags
DetailsFormatted DiffDiff
fix (3.18 KB, patch)
2013-03-26 12:43 PDT, Joe Mason 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joe Mason
Comment 1 2013-03-26 12:41:17 PDT
Created attachment 195145 [details] fix
Joe Mason
Comment 2 2013-03-26 12:43:55 PDT
Created attachment 195146 [details] fix Right patch this time
Rob Buis
Comment 3 2013-03-26 12:47:18 PDT
Comment on attachment 195146 [details] fix LGTM.
WebKit Review Bot
Comment 4 2013-03-26 13:06:58 PDT
Comment on attachment 195146 [details] fix Clearing flags on attachment: 195146 Committed r146922: <http://trac.webkit.org/changeset/146922>
WebKit Review Bot
Comment 5 2013-03-26 13:07:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.