Bug 113301

Summary: [Qt] Poor rounding in GraphicsContext::drawLineForText
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: WebKit QtAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: jturcotte, noam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 113199    
Attachments:
Description Flags
Patch none

Allan Sandfeld Jensen
Reported 2013-03-26 06:02:08 PDT
We truncate the position of the line in GraphicsContext::drawLineForText, this gives correct results as long as the coordinates coming in are integer. If we enable SUBPIXEL_LAYOUT however the positions coming in will often be fractions of pixels leading to bad rounding.
Attachments
Patch (1.56 KB, patch)
2013-03-26 06:03 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2013-03-26 06:03:51 PDT
Created attachment 195070 [details] Patch
WebKit Review Bot
Comment 2 2013-03-26 06:53:54 PDT
Comment on attachment 195070 [details] Patch Clearing flags on attachment: 195070 Committed r146878: <http://trac.webkit.org/changeset/146878>
WebKit Review Bot
Comment 3 2013-03-26 06:53:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.