| Summary: | Move remaining marquee applying code to StyleBuilder | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Emil A Eklund <eae> | ||||
| Component: | CSS | Assignee: | Emil A Eklund <eae> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | allan.jensen, eric, esprehn+autocc, macpherson, menard, ojan.autocc, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 89879 | ||||||
| Attachments: |
|
||||||
|
Description
Emil A Eklund
2013-03-26 05:16:49 PDT
Created attachment 195062 [details]
Patch
Comment on attachment 195062 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195062&action=review r=me, assuming we have layout tests of marquee CSS. > Source/WebCore/ChangeLog:12 > + No new tests, no change in functionality. Do we have tests testing marquee CSS? If not we should add some. (In reply to comment #2) > (From update of attachment 195062 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=195062&action=review > > r=me, assuming we have layout tests of marquee CSS. > > > Source/WebCore/ChangeLog:12 > > + No new tests, no change in functionality. > > Do we have tests testing marquee CSS? If not we should add some. We have a handful of tests for it, most notably fast/html/marquee-element.html and fast/css/MarqueeLayoutTest.html Comment on attachment 195062 [details] Patch Clearing flags on attachment: 195062 Committed r147350: <http://trac.webkit.org/changeset/147350> All reviewed patches have been landed. Closing bug. |