Bug 113287

Summary: [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, galpeter, hausmann, jturcotte, kadam, ossy, rniwa, zarvai, zeno
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 113191    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2013-03-26 02:50:24 PDT
It is to be able simplify master.cfg (https://bugs.webkit.org/show_bug.cgi?id=113191) and make run-qtwebkit-tests more user friendly, because you won't have to pass WebKitBuild/Release/Source/WebKit2/UIProcess/API/qt/tests/ for WK2 API tests or WebKitBuild/Release/Source/WebKit/qt/tests/ for WK1 API tests.
Attachments
Patch (3.86 KB, patch)
2013-03-26 03:34 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2013-03-26 03:34:51 PDT
Created attachment 195049 [details] Patch
Jocelyn Turcotte
Comment 2 2013-03-26 04:47:00 PDT
Comment on attachment 195049 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195049&action=review > Tools/Scripts/run-qtwebkit-tests:108 > + raise IndexError("Only one directory could be provided.") Nit: could -> should/must r=me
Csaba Osztrogonác
Comment 3 2013-03-26 04:48:16 PDT
(In reply to comment #2) > (From update of attachment 195049 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=195049&action=review > > > Tools/Scripts/run-qtwebkit-tests:108 > > + raise IndexError("Only one directory could be provided.") > > Nit: could -> should/must > > r=me I didn't touch this line, only moved. But will fix before landing.
Csaba Osztrogonác
Comment 4 2013-03-26 04:52:52 PDT
Committed r146868: <http://trac.webkit.org/changeset/146868>
Note You need to log in before you can comment on or make changes to this bug.