Summary: | Rename HTMLInputElement::isIndeterminate to Element::shouldAppearIndeterminate | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||
Component: | CSS | Assignee: | Kent Tamura <tkent> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aboxhall, allan.jensen, apinheiro, cfleizach, cmarcelo, dmazzoni, eric, esprehn+autocc, haraken, jdiggs, macpherson, menard, mifenton, morrita, ojan.autocc, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Kent Tamura
2013-03-25 19:15:04 PDT
Created attachment 194981 [details]
Patch
Comment on attachment 194981 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194981&action=review > Source/WebCore/html/HTMLProgressElement.cpp:173 > + return !isDeterminate(); As far as I see the removed code in SelectorChecker.cpp, it looks like that isDeterminate() is a negation of isIndeterminate(). In this patch, isIndeterminate() is remaned to shouldAppearIndeterminate(). Then, don't you want to rename isDeterminate() to something consistent as well (e.g. shouldAppearDeterminate()) ? Comment on attachment 194981 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194981&action=review >> Source/WebCore/html/HTMLProgressElement.cpp:173 >> + return !isDeterminate(); > > As far as I see the removed code in SelectorChecker.cpp, it looks like that isDeterminate() is a negation of isIndeterminate(). In this patch, isIndeterminate() is remaned to shouldAppearIndeterminate(). Then, don't you want to rename isDeterminate() to something consistent as well (e.g. shouldAppearDeterminate()) ? I understand you think it's inconsistent, however I feel it's not inconsistent because their roles are different. shouldAppearDeterminate is a hook for CSS selector matching, isDeterminate represents "determinate" concept in the standard and it is just for HTMLProgressElement. Comment on attachment 194981 [details]
Patch
Makes sense. Thanks for the clarification.
Comment on attachment 194981 [details] Patch Clearing flags on attachment: 194981 Committed r146860: <http://trac.webkit.org/changeset/146860> All reviewed patches have been landed. Closing bug. |