Bug 113261

Summary:

REGRESSION(r146657): NRWT shouldn't report image only failures when pixel tests are disabled

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Tools / Tests

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dpranke, ojan, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fixes the bug	none
Rebaselined the test	dpranke: review+

Ryosuke Niwa

Reported 2013-03-25 18:33:47 PDT

When a test failed flakily, we don't want to treat it as a failure or a flaky test even if the test failed with image only failure in retries.

Attachments
Fixes the bug (2.51 KB, patch) 2013-03-25 19:13 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Rebaselined the test (2.90 KB, patch) 2013-03-25 19:16 PDT, Ryosuke Niwa	dpranke: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2013-03-25 18:34:19 PDT

This bug was observed on http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r146827%20(7291)/results.html where a bunch of editing/unsupported-content/ tests were reported as failing even though they only had image only failures.

Ryosuke Niwa

Comment 2 2013-03-25 19:13:15 PDT

Ryosuke Niwa

Comment 3 2013-03-25 19:16:54 PDT

Created attachment 194980 [details] Rebaselined the test

Ryosuke Niwa

Comment 4 2013-03-25 20:21:27 PDT

Note You need to log in before you can comment on or make changes to this bug.