Bug 113228

Summary: Don't use video to trigger compositing for layout tests
Product: WebKit Reporter: Dana Jansens <danakj>
Component: New BugsAssignee: Dana Jansens <danakj>
Status: RESOLVED FIXED    
Severity: Normal CC: enne, jamesr, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 112971    
Attachments:
Description Flags
Patch
none
Patch
enne: review+
Patch none

Dana Jansens
Reported 2013-03-25 11:42:17 PDT
Don't use video to trigger compositing for layout tests
Attachments
Patch (16.82 KB, patch)
2013-03-25 11:48 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch (16.43 KB, patch)
2013-03-25 11:51 PDT, Dana Jansens 		enne: review+
DetailsFormatted DiffDiff
Patch (20.73 KB, patch)
2013-03-25 13:25 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dana Jansens
Comment 1 2013-03-25 11:48:37 PDT
Created attachment 194895 [details] Patch
Dana Jansens
Comment 2 2013-03-25 11:51:10 PDT
Created attachment 194896 [details] Patch rebase to head and typo in changelog
Adrienne Walker
Comment 3 2013-03-25 12:01:48 PDT
Comment on attachment 194896 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194896&action=review R=me. This looks great to me. Video has always been the cause of a lot of flaky layout tests. > LayoutTests/compositing/geometry/limit-layer-bounds-opacity-transition.html:15 > + width: 1px; It might be worth making this the size of the old video, in the same way that you resize compositing divs elsewhere to avoid expectation churn.
Dana Jansens
Comment 4 2013-03-25 12:14:31 PDT
Comment on attachment 194896 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194896&action=review >> LayoutTests/compositing/geometry/limit-layer-bounds-opacity-transition.html:15 >> + width: 1px; > > It might be worth making this the size of the old video, in the same way that you resize compositing divs elsewhere to avoid expectation churn. There was some churn anyway, unless I also added a 4px bottom border. It seemed kinda hokey and people in the future would be like "what?" I felt like. Given it's not just a width/height, do you feel differently? If not, I'm happy to add it.
Dana Jansens
Comment 5 2013-03-25 12:14:42 PDT
s/border/margin/
Dana Jansens
Comment 6 2013-03-25 13:25:44 PDT
Created attachment 194911 [details] Patch Missed a rebaseline of platform-specific results
WebKit Review Bot
Comment 7 2013-03-25 13:44:28 PDT
Comment on attachment 194911 [details] Patch Clearing flags on attachment: 194911 Committed r146814: <http://trac.webkit.org/changeset/146814>
Note You need to log in before you can comment on or make changes to this bug.