Bug 113212

Summary: [GTK] [gyp] Add support for building the platform directory
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, gustavo, thakis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 113213    
Attachments:
Description Flags
Patch none

Martin Robinson
Reported 2013-03-25 09:25:52 PDT
The platform directory holds the implementation of the platform layer.
Attachments
Patch (2.85 KB, patch)
2013-03-25 09:35 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2013-03-25 09:35:14 PDT
Created attachment 194871 [details] Patch
Nico Weber
Comment 2 2013-03-25 11:00:56 PDT
Comment on attachment 194871 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194871&action=review > Source/WebCore/ChangeLog:10 > + of Chromium. FYI: We use so many platforms in chromium due to the windows linker running out of memory otherwise (we have to use the 32 bit linker). If you don't need to support windows, you might be able to do with fewer targets if you like.
Martin Robinson
Comment 3 2013-03-25 11:05:09 PDT
(In reply to comment #2) > FYI: We use so many platforms in chromium due to the windows linker running out of memory otherwise (we have to use the 32 bit linker). > > If you don't need to support windows, you might be able to do with fewer targets if you like. We manage to have this same issue downstream on 32-bit systems as well. :(
Martin Robinson
Comment 4 2013-03-25 11:21:39 PDT
Comment on attachment 194871 [details] Patch Clearing flags on attachment: 194871 Committed r146789: <http://trac.webkit.org/changeset/146789>
Martin Robinson
Comment 5 2013-03-25 11:21:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.