Bug 113189

Summary:

Web Inspector: [Timeline] set glue records mode off by default

Product:

WebKit

Reporter:

Andrey Kosyakov <caseq>

Component:

Web Inspector (Deprecated)

Assignee:

Andrey Kosyakov <caseq>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, dglazkov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	pfeldman: review+, webkit.review.bot: commit-queue-
Archive of layout-test-results from gce-cr-linux-02 for chromium-linux-x86_64	none

Andrey Kosyakov

Reported 2013-03-25 05:00:07 PDT

In glue records, if inspected page produces excessive asynchronous events that get glued (e.g. repeated setTimeout()'s), timeline may exhibit O(n^2) dependency on number of records. This is due to continuous updating of parent records stats. The mode is generally seen as confusing, so turn it off by default.

Attachments
Patch (1.73 KB, patch) 2013-03-25 05:02 PDT, Andrey Kosyakov	pfeldman: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from gce-cr-linux-02 for chromium-linux-x86_64 (1.06 MB, application/zip) 2013-03-25 06:51 PDT, WebKit Review Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Andrey Kosyakov

Comment 1 2013-03-25 05:02:35 PDT

Created attachment 194831 [details] Patch

WebKit Review Bot

Comment 2 2013-03-25 06:51:51 PDT

Comment on attachment 194831 [details] Patch Attachment 194831 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17122961 New failing tests: inspector/timeline/timeline-receive-response-event.html

WebKit Review Bot

Comment 3 2013-03-25 06:51:55 PDT

Created attachment 194845 [details] Archive of layout-test-results from gce-cr-linux-02 for chromium-linux-x86_64 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-02 Port: chromium-linux-x86_64 Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

Andrey Kosyakov

Comment 4 2013-03-25 07:45:02 PDT

Committed r146771: <http://trac.webkit.org/changeset/146771>

Note You need to log in before you can comment on or make changes to this bug.