Summary: | [BlackBerry] add needReferer in WebPage load() api | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mary Wu <mawu> | ||||||
Component: | WebKit BlackBerry | Assignee: | Mary Wu <mawu> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | joenotcharles, mifenton, rwlbuis, staikos, tonikitoo, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Mary Wu
2013-03-24 19:51:49 PDT
Created attachment 194785 [details]
Patch
(In reply to comment #1) > Created an attachment (id=194785) [details] > Patch internally reviewed by Joe Mason. Comment on attachment 194785 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194785&action=review LGTM. > Source/WebKit/blackberry/ChangeLog:9 > + Sometimes when client load request, it need to add referer with curren frame like curren -> current. > Source/WebKit/blackberry/ChangeLog:10 > + save link/image in option menu, so we add needRef in load() interface in webpage. Sounds like you need to add Joe Mason as internal reviewer. (In reply to comment #3) > (From update of attachment 194785 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=194785&action=review > > LGTM. > > > Source/WebKit/blackberry/ChangeLog:9 > > + Sometimes when client load request, it need to add referer with curren frame like > > curren -> current. > > > Source/WebKit/blackberry/ChangeLog:10 > > + save link/image in option menu, so we add needRef in load() interface in webpage. > > Sounds like you need to add Joe Mason as internal reviewer. I thought I've added:p will update and push. thanks, Joe and Rob. Created attachment 194982 [details]
Patch
Comment on attachment 194982 [details] Patch Clearing flags on attachment: 194982 Committed r146845: <http://trac.webkit.org/changeset/146845> All reviewed patches have been landed. Closing bug. |