Bug 113167

Summary: [BlackBerry] add needReferer in WebPage load() api
Product: WebKit Reporter: Mary Wu <mawu>
Component: WebKit BlackBerryAssignee: Mary Wu <mawu>
Status: RESOLVED FIXED    
Severity: Normal CC: joenotcharles, mifenton, rwlbuis, staikos, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Mary Wu
Reported 2013-03-24 19:51:49 PDT
Sometimes when client load request, it need to add referer with curren frame like save link/image in option menu, so we add needRef in load() interface in webpage.
Attachments
Patch (8.95 KB, patch)
2013-03-24 21:01 PDT, Mary Wu 		no flags
DetailsFormatted DiffDiff
Patch (8.98 KB, patch)
2013-03-25 19:27 PDT, Mary Wu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mary Wu
Comment 1 2013-03-24 21:01:57 PDT
Created attachment 194785 [details] Patch
Mary Wu
Comment 2 2013-03-25 03:01:00 PDT
(In reply to comment #1) > Created an attachment (id=194785) [details] > Patch internally reviewed by Joe Mason.
Rob Buis
Comment 3 2013-03-25 04:46:09 PDT
Comment on attachment 194785 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194785&action=review LGTM. > Source/WebKit/blackberry/ChangeLog:9 > + Sometimes when client load request, it need to add referer with curren frame like curren -> current. > Source/WebKit/blackberry/ChangeLog:10 > + save link/image in option menu, so we add needRef in load() interface in webpage. Sounds like you need to add Joe Mason as internal reviewer.
Mary Wu
Comment 4 2013-03-25 19:06:24 PDT
(In reply to comment #3) > (From update of attachment 194785 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=194785&action=review > > LGTM. > > > Source/WebKit/blackberry/ChangeLog:9 > > + Sometimes when client load request, it need to add referer with curren frame like > > curren -> current. > > > Source/WebKit/blackberry/ChangeLog:10 > > + save link/image in option menu, so we add needRef in load() interface in webpage. > > Sounds like you need to add Joe Mason as internal reviewer. I thought I've added:p will update and push. thanks, Joe and Rob.
Mary Wu
Comment 5 2013-03-25 19:27:57 PDT
Created attachment 194982 [details] Patch
WebKit Review Bot
Comment 6 2013-03-25 20:15:31 PDT
Comment on attachment 194982 [details] Patch Clearing flags on attachment: 194982 Committed r146845: <http://trac.webkit.org/changeset/146845>
WebKit Review Bot
Comment 7 2013-03-25 20:15:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.