Bug 113154

Summary: [CSSRegions] Consolidate use of RenderRegion::isValid
Product: WebKit Reporter: Mihnea Ovidenie <mihnea>
Component: CSSAssignee: Mihnea Ovidenie <mihnea>
Status: RESOLVED FIXED    
Severity: Normal CC: abucur, eric, esprehn+autocc, ojan.autocc, WebkitBugTracker, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Mihnea Ovidenie
Reported 2013-03-24 10:09:10 PDT
After https://bugs.webkit.org/show_bug.cgi?id=98752, the list of invalid regions is kept separately. A valid region has always a valid flow thread attached. We can use isValid() throughout the RenderRegion code instead of testing for both isValid() and m_flowThread.
Attachments
Patch (12.05 KB, patch)
2013-03-24 10:22 PDT, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.33 KB, patch)
2013-03-28 00:25 PDT, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mihnea Ovidenie
Comment 1 2013-03-24 10:22:26 PDT
Created attachment 194758 [details] Patch
Dave Hyatt
Comment 2 2013-03-27 13:47:59 PDT
Comment on attachment 194758 [details] Patch r=me
Mihnea Ovidenie
Comment 3 2013-03-28 00:25:47 PDT
Created attachment 195492 [details] Patch for landing
WebKit Review Bot
Comment 4 2013-03-28 01:24:43 PDT
Comment on attachment 195492 [details] Patch for landing Clearing flags on attachment: 195492 Committed r147082: <http://trac.webkit.org/changeset/147082>
WebKit Review Bot
Comment 5 2013-03-28 01:24:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.