Bug 113104

Summary: Dashboard refactor: Move cross dashboard history related code into history.js.
Product: WebKit Reporter: Julie Parent <jparent>
Component: Tools / TestsAssignee: Julie Parent <jparent>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Julie Parent
Reported 2013-03-22 15:12:44 PDT
Dashboard refactor: Move cross dashboard history related code into history.js.
Attachments
Patch (83.83 KB, patch)
2013-03-22 15:17 PDT, Julie Parent 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julie Parent
Comment 1 2013-03-22 15:17:15 PDT
Created attachment 194640 [details] Patch
Ojan Vafai
Comment 2 2013-03-22 16:39:39 PDT
Comment on attachment 194640 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194640&action=review > Tools/TestResultServer/static-dashboards/history.js:112 > + this.crossDashboardState = {}; > + this.dashboardSpecificState = {}; I think we eventually want to find a way to make these private as well. Only the History object should know about cross-dashboard vs. dashboard specific parameters. But, that's probably easier to do once the rest of this cleanup is further along. > Tools/TestResultServer/static-dashboards/history.js:126 > + parseCrossDashboardParameters: function() We can make this private eventually too?
WebKit Review Bot
Comment 3 2013-03-25 12:40:12 PDT
Comment on attachment 194640 [details] Patch Clearing flags on attachment: 194640 Committed r146797: <http://trac.webkit.org/changeset/146797>
WebKit Review Bot
Comment 4 2013-03-25 12:40:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.