Bug 113072

Summary: [BlackBerry] Hit Test doesn't need to be active
Product: WebKit Reporter: gmak
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch with changelog
rwlbuis: review+, webkit.review.bot: commit-queue-
Patch none

Description gmak 2013-03-22 09:15:41 PDT
Should be read only in proximity detector
Comment 1 gmak 2013-03-22 10:25:37 PDT
Created attachment 194583 [details]
Patch with changelog
Comment 2 Rob Buis 2013-03-22 10:27:06 PDT
Comment on attachment 194583 [details]
Patch with changelog

Ok.
Comment 3 WebKit Review Bot 2013-03-22 10:29:20 PDT
Comment on attachment 194583 [details]
Patch with changelog

Rejecting attachment 194583 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 194583, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
it-queue

Parsed 2 diffs from patch file(s).
patching file Source/WebKit/blackberry/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/blackberry/WebKitSupport/ProximityDetector.cpp
Hunk #1 FAILED at 79.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/WebKitSupport/ProximityDetector.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://webkit-commit-queue.appspot.com/results/17234570
Comment 4 gmak 2013-03-22 10:46:18 PDT
Created attachment 194592 [details]
Patch
Comment 5 Rob Buis 2013-03-22 10:47:04 PDT
Comment on attachment 194592 [details]
Patch

Retrying.
Comment 6 WebKit Review Bot 2013-03-22 11:31:01 PDT
Comment on attachment 194592 [details]
Patch

Clearing flags on attachment: 194592

Committed r146634: <http://trac.webkit.org/changeset/146634>
Comment 7 WebKit Review Bot 2013-03-22 11:31:04 PDT
All reviewed patches have been landed.  Closing bug.