Bug 113054

Summary: -[TinyDOMNode dealloc] should call [super dealloc] when ARC is not enabled
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 112608    
Bug Blocks:    
Attachments:
Description Flags
Patch none

David Kilzer (:ddkilzer)
Reported 2013-03-22 07:12:08 PDT
* SUMMARY -[TinyDOMNode dealloc] should call [super dealloc] when ARC is not enabled.
Attachments
Patch (1.21 KB, patch)
2013-03-22 15:05 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2013-03-22 15:05:21 PDT
Created attachment 194637 [details] Patch
Geoffrey Garen
Comment 2 2013-03-22 15:19:14 PDT
Comment on attachment 194637 [details] Patch Do we ever compile in non-ARC mode?
Mark Hahnenberg
Comment 3 2013-03-22 15:28:22 PDT
(In reply to comment #2) > (From update of attachment 194637 [details]) > Do we ever compile in non-ARC mode? I believe it's possible with GCC. I think that's where ddkilzer ran into it.
WebKit Review Bot
Comment 4 2013-03-22 17:23:47 PDT
Comment on attachment 194637 [details] Patch Clearing flags on attachment: 194637 Committed r146688: <http://trac.webkit.org/changeset/146688>
WebKit Review Bot
Comment 5 2013-03-22 17:23:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.