Bug 113054 - -[TinyDOMNode dealloc] should call [super dealloc] when ARC is not enabled
Summary: -[TinyDOMNode dealloc] should call [super dealloc] when ARC is not enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on: 112608
Blocks:
  Show dependency tree / graph
 
Reported: 2013-03-22 07:12 PDT by David Kilzer (:ddkilzer)
Modified: 2013-03-22 17:23 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.21 KB, patch)
2013-03-22 15:05 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2013-03-22 07:12:08 PDT 
* SUMMARY
-[TinyDOMNode dealloc] should call [super dealloc] when ARC is not enabled.
Comment 1 Mark Hahnenberg 2013-03-22 15:05:21 PDT 
Created attachment 194637 [details]
Patch
Comment 2 Geoffrey Garen 2013-03-22 15:19:14 PDT 
Comment on attachment 194637 [details]
Patch

Do we ever compile in non-ARC mode?
Comment 3 Mark Hahnenberg 2013-03-22 15:28:22 PDT 
(In reply to comment #2)
> (From update of attachment 194637 [details])
> Do we ever compile in non-ARC mode?

I believe it's possible with GCC. I think that's where ddkilzer ran into it.
Comment 4 WebKit Review Bot 2013-03-22 17:23:47 PDT 
Comment on attachment 194637 [details]
Patch

Clearing flags on attachment: 194637

Committed r146688: <http://trac.webkit.org/changeset/146688>
Comment 5 WebKit Review Bot 2013-03-22 17:23:50 PDT 
All reviewed patches have been landed.  Closing bug.