Summary: | [BlackBerry] Memory leak in WebPagePrivate.cpp - NavigatorContentUtilsClientBlackBerry | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Xiaobo Wang <xiaobwang> | ||||||
Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | mifenton, rwlbuis, tonikitoo, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | Other | ||||||||
Attachments: |
|
Description
Xiaobo Wang
2013-03-21 20:18:59 PDT
Created attachment 194431 [details]
patch
PR 312552
Internally Reviewed by Anthony Scian.
Also fixed some webkit-style errors.
Attachment 194431 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPage.cpp', u'Source/WebKit/blackberry/Api/WebPage_p.h', u'Source/WebKit/blackberry/ChangeLog']" exit_code: 1
Source/WebKit/blackberry/Api/WebPage.cpp:3656: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Source/WebKit/blackberry/Api/WebPage.cpp:5495: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Total errors found: 2 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 195055 [details]
patch
Revised to only include my change.
Comment on attachment 195055 [details]
patch
LGTM.
Comment on attachment 195055 [details] patch Clearing flags on attachment: 195055 Committed r146960: <http://trac.webkit.org/changeset/146960> All reviewed patches have been landed. Closing bug. |