Bug 112934

Summary: [Windows, WinCairo] Correct Empty BitmapImage Test
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Tools / TestsAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: roger_fong, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Brent Fulgham
Reported 2013-03-21 11:09:54 PDT
The TestWebKitAPI test for an empty image frame (added in Bug 102689) incorrectly handles the reference counting aspects of the underlying BitmapImage object. This patch corrects a debug-build assertion that would trigger for the WinCairo port when running this test.
Attachments
Patch (1.36 KB, patch)
2013-03-21 11:30 PDT, Brent Fulgham 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2013-03-21 11:27:27 PDT
Note that even with this patch we cannot run this test under the Windows CG build because the implementation of ImageSourceCG asserts that its internal frameCount method is non-zero. Since we do not provide an underlying CG image source for this test, the assertion will always fire.
Brent Fulgham
Comment 2 2013-03-21 11:30:29 PDT
Created attachment 194303 [details] Patch
Brent Fulgham
Comment 3 2013-03-21 17:08:49 PDT
Landed in r146507.
Note You need to log in before you can comment on or make changes to this bug.