Summary: | [Skia] Integration of the Skia displacement mapping into WebKit | ||
---|---|---|---|
Product: | WebKit | Reporter: | sugoi |
Component: | New Bugs | Assignee: | sugoi |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | buildbot, dglazkov, dino, junov, rniwa, senorblanco, webkit.review.bot |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Attachments: |
Description
sugoi
2013-03-21 10:12:15 PDT
Created attachment 194611 [details]
Patch
Comment on attachment 194611 [details] Patch Attachment 194611 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17218638 New failing tests: css3/filters/effect-reference-hw.html css3/filters/effect-reference.html Created attachment 194621 [details]
Archive of layout-test-results from webkit-ews-16
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16 Port: <class 'webkitpy.common.config.ports.MacWK2Port'> Platform: Mac OS X 10.8.2
Comment on attachment 194611 [details] Patch Attachment 194611 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17120792 New failing tests: css3/filters/effect-reference-hw.html css3/filters/effect-reference.html Created attachment 194622 [details]
Archive of layout-test-results from gce-cr-linux-05
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-05 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04
Comment on attachment 194611 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194611&action=review You'll need to add some results for at least one platform. It looks like the auto-attaching-failed-results thing is fixed, so I think both the Chromium and Mac (Safari) results are now available. You should be able to download those and integrate them into your patch. > Source/WebCore/platform/graphics/filters/skia/FEDisplacementMapSkia.cpp:38 > +SkDisplacementMapEffect::ChannelSelectorType toSkiaMode(ChannelSelectorType type) Nit: this should be static, or in the unnamed namespace. Comment on attachment 194611 [details] Patch Attachment 194611 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17178771 New failing tests: css3/filters/effect-reference-hw.html css3/filters/effect-reference.html Created attachment 194628 [details]
Archive of layout-test-results from webkit-ews-10
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10 Port: <class 'webkitpy.common.config.ports.MacWK2Port'> Platform: Mac OS X 10.8.2
Comment on attachment 194611 [details] Patch Attachment 194611 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/17289184 New failing tests: css3/filters/effect-reference-hw.html css3/filters/effect-reference.html Created attachment 194699 [details]
Archive of layout-test-results from webkit-ews-03 for mac-future
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03 Port: mac-future Platform: Mac OS X 10.8.2
Created attachment 194859 [details]
Patch
Comment on attachment 194859 [details]
Patch
Looks good, bots willing. r=me
Comment on attachment 194859 [details] Patch Clearing flags on attachment: 194859 Committed r146779: <http://trac.webkit.org/changeset/146779> All reviewed patches have been landed. Closing bug. |