Bug 112915

Summary: [BlackBerry] Add ScrollingCoordinatorBlackBerry implementation
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, anilsson, cmarcelo, gyuyoung.kim, jamesr, luiz, rakuco, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Updated patch none

Carlos Garcia Campos
Reported 2013-03-21 07:46:43 PDT
Upstream the ScrollingCoordinatorBlackBerry files.
Attachments
Patch (9.70 KB, patch)
2013-03-21 07:53 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Updated patch (9.72 KB, patch)
2013-03-21 08:32 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2013-03-21 07:53:21 PDT
Created attachment 194260 [details] Patch
Rob Buis
Comment 2 2013-03-21 08:24:53 PDT
Comment on attachment 194260 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194260&action=review > Source/WebCore/page/scrolling/blackberry/ScrollingCoordinatorBlackBerry.cpp:43 > +void ScrollingCoordinatorBlackBerry::setLayerIsContainerForFixedPositionLayers(GraphicsLayer* layer, bool b) I think bool b is not a good param name. > Source/WebCore/page/scrolling/blackberry/ScrollingCoordinatorBlackBerry.cpp:49 > +void ScrollingCoordinatorBlackBerry::setLayerIsFixedToContainerLayer(GraphicsLayer* layer, bool b) Ditto.
Carlos Garcia Campos
Comment 3 2013-03-21 08:32:10 PDT
Created attachment 194267 [details] Updated patch Fixed style issues
Rob Buis
Comment 4 2013-03-21 08:50:46 PDT
Comment on attachment 194267 [details] Updated patch LGTM.
WebKit Review Bot
Comment 5 2013-03-21 09:34:40 PDT
Comment on attachment 194267 [details] Updated patch Clearing flags on attachment: 194267 Committed r146478: <http://trac.webkit.org/changeset/146478>
WebKit Review Bot
Comment 6 2013-03-21 09:34:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.