Bug 112915 - [BlackBerry] Add ScrollingCoordinatorBlackBerry implementation
Summary: [BlackBerry] Add ScrollingCoordinatorBlackBerry implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-21 07:46 PDT by Carlos Garcia Campos
Modified: 2013-03-21 09:34 PDT (History)
10 users (show)

See Also:

Attachments
Patch (9.70 KB, patch)
2013-03-21 07:53 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Updated patch (9.72 KB, patch)
2013-03-21 08:32 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2013-03-21 07:46:43 PDT 
Upstream the ScrollingCoordinatorBlackBerry files.
Comment 1 Carlos Garcia Campos 2013-03-21 07:53:21 PDT 
Created attachment 194260 [details]
Patch
Comment 2 Rob Buis 2013-03-21 08:24:53 PDT 
Comment on attachment 194260 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194260&action=review

> Source/WebCore/page/scrolling/blackberry/ScrollingCoordinatorBlackBerry.cpp:43
> +void ScrollingCoordinatorBlackBerry::setLayerIsContainerForFixedPositionLayers(GraphicsLayer* layer, bool b)

I think bool b is not a good param name.

> Source/WebCore/page/scrolling/blackberry/ScrollingCoordinatorBlackBerry.cpp:49
> +void ScrollingCoordinatorBlackBerry::setLayerIsFixedToContainerLayer(GraphicsLayer* layer, bool b)

Ditto.
Comment 3 Carlos Garcia Campos 2013-03-21 08:32:10 PDT 
Created attachment 194267 [details]
Updated patch

Fixed style issues
Comment 4 Rob Buis 2013-03-21 08:50:46 PDT 
Comment on attachment 194267 [details]
Updated patch

LGTM.
Comment 5 WebKit Review Bot 2013-03-21 09:34:40 PDT 
Comment on attachment 194267 [details]
Updated patch

Clearing flags on attachment: 194267

Committed r146478: <http://trac.webkit.org/changeset/146478>
Comment 6 WebKit Review Bot 2013-03-21 09:34:44 PDT 
All reviewed patches have been landed.  Closing bug.