Bug 112911 – Web Inspector: generalize InspectorDOMAgent::highlightRect() to highlightQuad()

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Andrey Kosyakov]

We need to highlight paint in transformed layers, so paint rectangles would become quads. This generalizes existing highlight for rectangles to handle quads.

[Andrey Kosyakov]

Created attachment 194255 [details]
Patch

[Timothy Hatcher]

Comment on attachment 194255 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194255&action=review

> Source/WebCore/inspector/Inspector.json:1779
> +                "id": "Quad",
> +                "type": "array",
> +                "items": { "type": "number" },
> +                "minItems": 8,
> +                "maxItems": 8,
> +                "description": "An array of quad vertices, x immediately followed by y for each point, points clock-wise."

An 4 item array of point objects with x and y properties would be more clear.

[Pavel Feldman]

Comment on attachment 194255 [details]
Patch

As per Timothy's comment.

[Andrey Kosyakov]

Comment on attachment 194255 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194255&action=review

>> Source/WebCore/inspector/Inspector.json:1779
>> +                "description": "An array of quad vertices, x immediately followed by y for each point, points clock-wise."
> 
> An 4 item array of point objects with x and y properties would be more clear.

This is used in entries that are quite frequent (and will perhaps be used even more), so we're trying to save a few bytes on both protocol message and timeline log sizes, as well as use representation that would hopefully be marginally cheaper for VM. On the other hand, there will be almost no access to Quad member in the front-end code, except for length/width calculation, so most of the time it will be treated as opaque object passed to highlightQuad.

[Andrey Kosyakov]

(In reply to comment #3)
> (From update of attachment 194255 [details])
> As per Timothy's comment.

As discussed offline, this is motivated mostly by performance concerns.

[Andrey Kosyakov]

Committed r147202: <http://trac.webkit.org/changeset/147202>