Bug 112897

Summary:

When table cell have inline children which change writing-mode, the cell overflows its contents.

Product:

WebKit

Reporter:

Yuki Sekiguchi <yuki.sekiguchi>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, dglazkov, eric, esprehn+autocc, glenn, kondapallykalyan, ojan.autocc, rniwa, webkit-bug-importer, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
reproduced html content	none
Patch	none
Archive of layout-test-results from gce-cr-linux-06	none
Patch	none
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion	none
Patch	none
Patch	none

Yuki Sekiguchi

Reported 2013-03-21 03:57:30 PDT

Created attachment 194220 [details] reproduced html content In the attached content, span element in the 1st table is overflowed. Table should not overflow its content in normal case. Table likely use contents width not height to calculate its cell width.

Attachments
reproduced html content (543 bytes, text/html) 2013-03-21 03:57 PDT, Yuki Sekiguchi	no flags	Details
Patch (12.13 KB, patch) 2013-03-21 04:19 PDT, Yuki Sekiguchi	no flags	Details Formatted Diff Diff
Archive of layout-test-results from gce-cr-linux-06 (585.88 KB, application/zip) 2013-03-21 06:53 PDT, WebKit Review Bot	no flags	Details
Patch (10.20 KB, patch) 2014-02-05 21:06 PST, Yuki Sekiguchi	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (457.97 KB, application/zip) 2014-02-05 22:00 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (492.00 KB, application/zip) 2014-02-05 22:25 PST, Build Bot	no flags	Details
Patch (14.96 KB, patch) 2014-02-05 22:35 PST, Yuki Sekiguchi	no flags	Details Formatted Diff Diff
Patch (16.75 KB, patch) 2014-02-06 02:25 PST, Yuki Sekiguchi	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Yuki Sekiguchi

Comment 1 2013-03-21 04:19:07 PDT

Created attachment 194222 [details] Patch

WebKit Review Bot

Comment 2 2013-03-21 06:53:43 PDT

Comment on attachment 194222 [details] Patch Attachment 194222 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17200565 New failing tests: fast/table/colspanMinWidth-vertical.html

WebKit Review Bot

Comment 3 2013-03-21 06:53:46 PDT

Created attachment 194251 [details] Archive of layout-test-results from gce-cr-linux-06 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-06 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

Andreas Kling

Comment 4 2014-02-05 11:25:47 PST

Comment on attachment 194222 [details] Patch Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.

Yuki Sekiguchi

Comment 5 2014-02-05 21:06:41 PST

Created attachment 223303 [details] Patch

Build Bot

Comment 6 2014-02-05 22:00:48 PST

Comment on attachment 223303 [details] Patch Attachment 223303 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6415375268839424 New failing tests: fast/table/colspanMinWidth-vertical.html

Build Bot

Comment 7 2014-02-05 22:00:51 PST

Created attachment 223307 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 8 2014-02-05 22:25:15 PST

Comment on attachment 223303 [details] Patch Attachment 223303 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5232251365228544 New failing tests: fast/table/colspanMinWidth-vertical.html

Build Bot

Comment 9 2014-02-05 22:25:18 PST

Created attachment 223308 [details] Archive of layout-test-results from webkit-ews-05 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Yuki Sekiguchi

Comment 10 2014-02-05 22:35:54 PST

Created attachment 223312 [details] Patch

Yuki Sekiguchi

Comment 11 2014-02-06 02:18:01 PST

I landed the same patch to Blink at http://src.chromium.org/viewvc/blink?view=revision&revision=163239

Yuki Sekiguchi

Comment 12 2014-02-06 02:25:25 PST

Created attachment 223319 [details] Patch

Michael Catanzaro

Comment 13 2016-09-17 07:18:32 PDT

Comment on attachment 223319 [details] Patch Hi, Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting. To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug.

EWS

Comment 14 2022-10-24 09:56:39 PDT

Committed 255919@main (29a59ed73e09): <https://commits.webkit.org/255919@main> Reviewed commits have been landed. Closing PR #5679 and removing active labels.

Radar WebKit Bug Importer

Comment 15 2022-10-24 09:57:19 PDT

<rdar://problem/101504664>

Note You need to log in before you can comment on or make changes to this bug.