Bug 112892

Summary: WinCairo build fails to link.
Product: WebKit Reporter: peavo
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, haraken, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Unspecified   
Attachments:
Description Flags
Patch none

peavo
Reported 2013-03-21 02:55:02 PDT
The VS2005 WinCairo build fails with the following linker error: WebKit.exp : error LNK2001: unresolved external symbol "public: class WebCore::CaptionUserPreferences * __thiscall WebCore::PageGroup::captionPreferences(void)" (?captionPreferences@PageGroup@WebCore@@QAEPAVCaptionUserPreferences@2@XZ) C:\webkitdist\Release_Cairo_CFLite\bin\WebKit.dll : fatal error LNK1120: 1 unresolved externals
Attachments
Patch (1.41 KB, patch)
2013-03-21 03:00 PDT, peavo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
peavo
Comment 1 2013-03-21 03:00:29 PDT
Created attachment 194211 [details] Patch
Kentaro Hara
Comment 2 2013-03-21 17:57:00 PDT
Comment on attachment 194211 [details] Patch rs=me
WebKit Review Bot
Comment 3 2013-03-21 18:34:53 PDT
Comment on attachment 194211 [details] Patch Clearing flags on attachment: 194211 Committed r146550: <http://trac.webkit.org/changeset/146550>
WebKit Review Bot
Comment 4 2013-03-21 18:34:56 PDT
All reviewed patches have been landed. Closing bug.
Brent Fulgham
Comment 5 2013-03-22 09:21:26 PDT
Thanks for fixing this. I corrected it in the VS2010 build, but forgot to check the VS2005 side!
Note You need to log in before you can comment on or make changes to this bug.