Bug 112827

Summary: [SVG] Remove explicit LightSource dispatchers
Product: WebKit Reporter: Florin Malita <fmalita>
Component: SVGAssignee: Florin Malita <fmalita>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, gyuyoung.kim, krit, pdr, rakuco, schenney, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Florin Malita
Reported 2013-03-20 12:30:10 PDT
Currently, LightSource implements a series of methods whose sole purpose is dispatching to sub-classes based on a type field. By using virtual dispatchers, we could: * eliminate all the static casts * remove LightSource.cpp altogether
Attachments
Patch (18.56 KB, patch)
2013-03-20 12:37 PDT, Florin Malita 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Florin Malita
Comment 1 2013-03-20 12:37:31 PDT
Created attachment 194096 [details] Patch
Stephen Chenney
Comment 2 2013-03-21 12:26:34 PDT
Comment on attachment 194096 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194096&action=review Good find. Security will be happy. > Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:13644 > +</Project> We probably shouldn't reorder these lines.
Florin Malita
Comment 3 2013-03-21 12:53:26 PDT
Thanks Stephen. (In reply to comment #2) > > Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:13644 > > +</Project> > > We probably shouldn't reorder these lines. I think that's just git diff getting confused - there's no "\ No newline at end of file" line in that file...
WebKit Review Bot
Comment 4 2013-03-21 13:05:07 PDT
Comment on attachment 194096 [details] Patch Clearing flags on attachment: 194096 Committed r146503: <http://trac.webkit.org/changeset/146503>
WebKit Review Bot
Comment 5 2013-03-21 13:05:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.