Bug 112825 – [Chromium] Move openFileSystem and deleteFileSystem to Platform.h

• Component: WebKit Misc.
• Status: RESOLVED WONTFIX

[Mark Pilgrim (Google)]

[Chromium] Move openFileSystem and deleteFileSystem to Platform.h

[Mark Pilgrim (Google)]

Created attachment 194091 [details]
Patch

[Mark Pilgrim (Google)]

Comment on attachment 194091 [details]
Patch

Needs changes in Chromium to land first (adding the actual implementation).

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Adam Barth]

Comment on attachment 194091 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194091&action=review

> Source/Platform/chromium/public/Platform.h:182
> +    virtual void openFileSystem(
> +        WebString, WebFileSystemType, long long size,
> +        bool create, WebFileSystemCallbacks*) { }

We can put this all on one line.

Is there a reason to put this on Platform directly instead of on WebFileSystem?

> Source/Platform/chromium/public/Platform.h:191
> +    virtual void deleteFileSystem(
> +        WebString, WebFileSystemType, WebFileSystemCallbacks*) { }

ditto

[Adam Barth]

Comment on attachment 194091 [details]
Patch

(modulo question above)

[WebKit Review Bot]

Comment on attachment 194091 [details]
Patch

Attachment 194091 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17129728

New failing tests:
http/tests/security/filesystem-iframe-from-remote.html
fast/filesystem/workers/file-writer-sync-truncate-extend.html
http/tests/filesystem/workers/resolve-url.html
http/tests/cache/subresource-failover-to-network.html
fast/css/font-family-pictograph.html
http/tests/inspector/filesystem/delete-entry.html
fast/filesystem/file-from-file-entry.html
fast/filesystem/workers/file-writer-gc-blob.html
fast/filesystem/directory-entry-to-uri.html
http/tests/security/contentSecurityPolicy/filesystem-urls-match-self.html
http/tests/filesystem/workers/resolve-url-sync.html
fast/filesystem/workers/file-from-file-entry-sync.html
fast/filesystem/file-writer-abort-continue.html
http/tests/filesystem/no-cache-filesystem-url.html
fast/filesystem/workers/file-writer-empty-blob.html
fast/filesystem/async-operations.html
http/tests/inspector/filesystem/request-file-content.html
fast/filesystem/file-entry-to-uri.html
http/tests/inspector/filesystem/request-metadata.html
fast/filesystem/workers/file-writer-events.html
http/tests/inspector/filesystem/request-directory-content.html
fast/filesystem/file-metadata-after-write.html
http/tests/filesystem/resolve-uri.html
http/tests/inspector/filesystem/directory-tree.html
fast/filesystem/file-after-reload-crash.html
fast/filesystem/workers/file-entry-to-uri-sync.html
fast/dom/MutationObserver/filesystem-callback-delivery.html
fast/filesystem/workers/file-from-file-entry.html
http/tests/inspector/filesystem/request-filesystem-root.html
fast/filesystem/cross-filesystem-op.html