Bug 112794

Summary: [EFL][WK2] Do not allow passing null pointers for *Ref types
Product: WebKit Reporter: Kenneth Rohde Christiansen <kenneth>
Component: WebKit EFLAssignee: Kenneth Rohde Christiansen <kenneth>
Status: RESOLVED WONTFIX    
Severity: Normal CC: ap, benjamin, cdumez, gyuyoung.kim, kling, lucas.de.marchi, mcatanzaro, mikhail.pozdnyakov, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 107820    
Attachments:
Description Flags
Patch cdumez: review+

Kenneth Rohde Christiansen
Reported 2013-03-20 05:58:55 PDT
SSIA
Attachments
Patch (3.46 KB, patch)
2013-03-20 06:00 PDT, Kenneth Rohde Christiansen 		cdumez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Rohde Christiansen
Comment 1 2013-03-20 06:00:33 PDT
Created attachment 194028 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2013-03-20 06:06:30 PDT
*** Bug 109276 has been marked as a duplicate of this bug. ***
Mikhail Pozdnyakov
Comment 3 2013-03-20 06:07:05 PDT
Comment on attachment 194028 [details] Patch LGTM
Mikhail Pozdnyakov
Comment 4 2013-03-20 06:07:42 PDT
Comment on attachment 194028 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194028&action=review > Source/WebKit2/UIProcess/API/C/efl/WKView.h:53 > +WK_EXPORT WKViewRef WKViewCreateWithPageGroup(WKContextRef context, WKPageGroupRef pageGroup); nit: variable names can be omitted
Chris Dumez
Comment 5 2013-03-20 06:09:07 PDT
Comment on attachment 194028 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194028&action=review > Source/WebKit2/UIProcess/API/C/efl/WKView.cpp:41 > RefPtr<WebView> webView = WebView::create(toImpl(contextRef), toImpl(pageGroupRef)); How about null-check assertions for args?
Kenneth Rohde Christiansen
Comment 6 2013-03-20 06:12:35 PDT
> How about null-check assertions for args? I don't mind and I can do that if a reviewer thinks that makes sense. The asserts could also be in toImpl/toAPI instead.
Chris Dumez
Comment 7 2013-03-20 06:13:35 PDT
(In reply to comment #6) > > How about null-check assertions for args? > > I don't mind and I can do that if a reviewer thinks that makes sense. The asserts could also be in toImpl/toAPI instead. Right, other C API code does not usually use assertions either. LGTM then.
Kenneth Rohde Christiansen
Comment 8 2013-03-20 06:20:36 PDT
Ping owner review/sign off.
Chris Dumez
Comment 9 2013-05-16 13:06:26 PDT
Comment on attachment 194028 [details] Patch Entirely port specific so it should no longer require owner review. r=me.
Michael Catanzaro
Comment 10 2017-03-11 10:37:12 PST
Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.
Note You need to log in before you can comment on or make changes to this bug.