Bug 112768

Summary:

It's called "Hash Consing" not "Hash Consting"

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch for landing	none

Filip Pizlo

Reported 2013-03-19 18:33:07 PDT

Patch forthcoming. Already rubber stamped by Mark Hahnenberg.

Attachments
patch for landing (11.76 KB, patch) 2013-03-19 18:33 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2013-03-19 18:33:39 PDT

Created attachment 193964 [details] patch for landing Just want to make sure it won't set fire to the universe.

WebKit Review Bot

Comment 2 2013-03-19 18:35:07 PDT

Attachment 193964 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/heap/GCThreadSharedData.cpp', u'Source/JavaScriptCore/heap/GCThreadSharedData.h', u'Source/JavaScriptCore/heap/SlotVisitor.cpp', u'Source/JavaScriptCore/heap/SlotVisitor.h', u'Source/JavaScriptCore/runtime/JSGlobalData.cpp', u'Source/JavaScriptCore/runtime/JSGlobalData.h', u'Source/JavaScriptCore/runtime/JSString.h']" exit_code: 1 Source/JavaScriptCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 3 2013-03-20 13:46:11 PDT

Landed in http://trac.webkit.org/changeset/146382

Note You need to log in before you can comment on or make changes to this bug.