Bug 112747

Summary:

Add color profile support for WebP images

Product:

WebKit

Reporter:

Urvang Joshi <urvang>

Component:

Images

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

dglazkov, noel.gordon, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

113124

Attachments:

Description	Flags
Patch	none
Patch	none
Looks like we need to bump up the decoder ABI version in conditional	darin: review-, webkit.review.bot: commit-queue-

Urvang Joshi

Reported 2013-03-19 14:49:42 PDT

Color profile support is being added to WebP in v0.3.0. This bug regarding adding the same support in WebKit.

Attachments
Patch (664.26 KB, patch) 2013-03-19 15:07 PDT, Urvang Joshi	no flags	Details Formatted Diff Diff
Patch (664.28 KB, patch) 2013-03-19 15:26 PDT, Urvang Joshi	no flags	Details Formatted Diff Diff
Looks like we need to bump up the decoder ABI version in conditional (664.28 KB, patch) 2013-03-19 15:41 PDT, Urvang Joshi	darin: review- webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Urvang Joshi

Comment 1 2013-03-19 15:07:04 PDT

Created attachment 193932 [details] Patch

WebKit Review Bot

Comment 2 2013-03-19 15:09:21 PDT

Attachment 193932 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/images/resources/webp-color-profile-lossless.webp', u'LayoutTests/fast/images/resources/webp-color-profile-lossy-alpha.webp', u'LayoutTests/fast/images/resources/webp-color-profile-lossy.webp', u'LayoutTests/fast/images/webp-color-profile-lossless-expected.txt', u'LayoutTests/fast/images/webp-color-profile-lossless.html', u'LayoutTests/fast/images/webp-color-profile-lossy-alpha-expected.txt', u'LayoutTests/fast/images/webp-color-profile-lossy-alpha.html', u'LayoutTests/fast/images/webp-color-profile-lossy-expected.txt', u'LayoutTests/fast/images/webp-color-profile-lossy.html', u'LayoutTests/platform/chromium-mac/fast/images/webp-color-profile-lossless-expected.png', u'LayoutTests/platform/chromium-mac/fast/images/webp-color-profile-lossy-alpha-expected.png', u'LayoutTests/platform/chromium-mac/fast/images/webp-color-profile-lossy-expected.png', u'LayoutTests/platform/chromium-win/fast/images/webp-color-profile-lossless-expected.png', u'LayoutTests/platform/chromium-win/fast/images/webp-color-profile-lossy-alpha-expected.png', u'LayoutTests/platform/chromium-win/fast/images/webp-color-profile-lossy-expected.png', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/image-decoders/webp/WEBPImageDecoder.cpp', u'Source/WebCore/platform/image-decoders/webp/WEBPImageDecoder.h']" exit_code: 1 Source/WebCore/platform/image-decoders/webp/WEBPImageDecoder.h:61: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/image-decoders/webp/WEBPImageDecoder.h:62: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/image-decoders/webp/WEBPImageDecoder.h:63: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 3 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 3 2013-03-19 15:23:25 PDT

Comment on attachment 193932 [details] Patch Attachment 193932 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17197548

Urvang Joshi

Comment 4 2013-03-19 15:26:18 PDT

Created attachment 193936 [details] Patch

Urvang Joshi

Comment 5 2013-03-19 15:41:37 PDT

Created attachment 193938 [details] Looks like we need to bump up the decoder ABI version in conditional

WebKit Review Bot

Comment 6 2013-03-19 17:43:40 PDT

Comment on attachment 193938 [details] Looks like we need to bump up the decoder ABI version in conditional Attachment 193938 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17257094 New failing tests: platform/chromium/virtual/deferred/fast/images/webp-color-profile-lossy-alpha.html fast/images/webp-color-profile-lossy.html platform/chromium/virtual/deferred/fast/images/webp-color-profile-lossless.html fast/images/webp-color-profile-lossless.html fast/images/webp-color-profile-lossy-alpha.html platform/chromium/virtual/deferred/fast/images/webp-color-profile-lossy.html

Urvang Joshi

Comment 7 2013-03-19 22:07:54 PDT

The failing tests are due to the the 'Depends-on' change (https://bugs.webkit.org/show_bug.cgi?id=112761) being pending.

noel gordon

Comment 8 2013-03-25 05:05:43 PDT

This code doesn't compile after libewebp landed in webkit in bug 113184. As discussed, I will take over and complete the remaining tasks. Opened bug 113184 for that. Closing this bug (wont fix).

Darin Adler

Comment 9 2013-09-13 08:19:12 PDT

Comment on attachment 193938 [details] Looks like we need to bump up the decoder ABI version in conditional If someone wants a newer version of the WebP decoder in WebKit I think a good way would be to get the latest version from Blink project. This patch is old enough that it still has chromium layout test changes in it, so we can’t take this patch as is.

Note You need to log in before you can comment on or make changes to this bug.