Bug 112727

Summary: [GTK] Add WebCoreHTML to the gyp build
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, gustavo, thakis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 112638    
Bug Blocks: 112737    
Attachments:
Description Flags
Patch thakis: review+

Martin Robinson
Reported 2013-03-19 11:43:55 PDT
WebCoreHTML includes all the HTML files. HTML is useful for a web content rendering engine.
Attachments
Patch (4.12 KB, patch)
2013-03-19 11:46 PDT, Martin Robinson 		thakis: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2013-03-19 11:46:58 PDT
Created attachment 193883 [details] Patch
Nico Weber
Comment 2 2013-03-19 20:25:17 PDT
Comment on attachment 193883 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193883&action=review Makes sense. > Source/WebCore/WebCore.gyp/WebCoreGTK.gyp:921 > + 'type': 'none', Does linking to a none target that depends on two static_library targets do the right thing? (i.e. link in the two static libraries)
Martin Robinson
Comment 3 2013-03-22 16:50:13 PDT
Committed r146680: <http://trac.webkit.org/changeset/146680>
Martin Robinson
Comment 4 2013-03-25 09:27:27 PDT
(In reply to comment #2) > > Source/WebCore/WebCore.gyp/WebCoreGTK.gyp:921 > > + 'type': 'none', > > Does linking to a none target that depends on two static_library targets do the right thing? (i.e. link in the two static libraries) Hrm. I haven't built out to libwebkit (I'm pretty close now though), but this seems to be how the Chromium build is structured.
Note You need to log in before you can comment on or make changes to this bug.